Includes Ember tests for yanking

Author: thiagoarrais

app/components/yank-button.hbs

@@ -3,6 +3,7 @@
     type="button"
     local-class="button"
     ...attributes
+    data-test-version-unyank-button={{@version.num}}
     disabled={{@version.unyankTask.isRunning}}
     {{on "click" (perform @version.unyankTask)}}
   >
@@ -17,6 +18,7 @@
     type="button"
     local-class="button"
     ...attributes
+    data-test-version-yank-button={{@version.num}}
     disabled={{@version.yankTask.isRunning}}
     {{on "click" (perform @version.yankTask)}}
   >

app/models/version.js

@@ -75,7 +75,7 @@ export default class Version extends Model {
   @(task(function* () {
     let response = yield fetch(`/api/v1/crates/${this.crate.id}/${this.num}/unyank`, { method: 'PUT' });
     if (!response.ok) {
-      throw new Error(`Yank request for ${this.crateName} v${this.num} failed`);
+      throw new Error(`Unyank request for ${this.crateName} v${this.num} failed`);
     }
     this.set('yanked', false);
 

mirage/route-handlers/crates.js

@@ -254,4 +254,28 @@ export function register(server) {
 
     return {};
   });
+
+  server.delete('/api/v1/crates/:crate_id/:version/yank', (schema, request) => {
+    const crateId = request.params.crate_id;
+    const versionNum = request.params.version;
+
+    const version = schema.versions.findBy({ crateId, num: versionNum });
+    if (!version) {
+      return notFound();
+    }
+
+    return {};
+  });
+
+  server.put('/api/v1/crates/:crate_id/:version/unyank', (schema, request) => {
+    const crateId = request.params.crate_id;
+    const versionNum = request.params.version;
+
+    const version = schema.versions.findBy({ crateId, num: versionNum });
+    if (!version) {
+      return notFound();
+    }
+
+    return {};
+  });
 }

tests/acceptance/crate-test.js

@@ -1,4 +1,4 @@
-import { click, fillIn, currentURL, currentRouteName, visit } from '@ember/test-helpers';
+import { click, fillIn, currentURL, currentRouteName, visit, waitFor } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 import { module, test } from 'qunit';
 
@@ -219,6 +219,25 @@ module('Acceptance | crate page', function (hooks) {
     assert.dom('[data-test-license]').hasText('MIT/Apache-2.0');
   });
 
+  test('crates can be yanked by owner', async function (assert) {
+    this.server.loadFixtures();
+
+    let user = this.server.schema.users.findBy({ login: 'thehydroimpulse' });
+    this.authenticateAs(user);
+
+    await visit('/crates/nanomsg');
+    await click('[data-test-version-yank-button="0.5.0"]');
+    assert.dom('[data-test-version-yank-button="0.5.0"]').hasText('Yanking...');
+    assert.dom('[data-test-version-yank-button="0.5.0"]').isDisabled();
+
+    await waitFor('[data-test-version-unyank-button="0.5.0"]');
+    await click('[data-test-version-unyank-button="0.5.0"]');
+    assert.dom('[data-test-version-unyank-button="0.5.0"]').hasText('Unyanking...');
+    assert.dom('[data-test-version-unyank-button="0.5.0"]').isDisabled();
+
+    await waitFor('[data-test-version-yank-button="0.5.0"]');
+  });
+
   test('navigating to the owners page when not logged in', async function (assert) {
     this.server.loadFixtures();