publish: Inline validate_dependencies() fn

Author: Turbo87

src/controllers/krate/publish.rs

@@ -284,8 +284,11 @@ pub async fn publish(app: AppState, req: BytesRequest) -> AppResult<Json<GoodCra
                 VersionAction::Publish,
             )?;
 
+            for dep in &metadata.deps {
+                validate_dependency(dep)?;
+            }
+
             // Link this new version to all dependencies
-            validate_dependencies(&metadata.deps)?;
             add_dependencies(conn, &metadata.deps, version.id)?;
 
             // Update all keywords for this crate
@@ -431,15 +434,6 @@ fn missing_metadata_error_message(missing: &[&str]) -> String {
     )
 }
 
-#[instrument(skip_all)]
-pub fn validate_dependencies(deps: &[EncodableCrateDependency]) -> AppResult<()> {
-    for dep in deps {
-        validate_dependency(dep)?;
-    }
-
-    Ok(())
-}
-
 pub fn validate_dependency(dep: &EncodableCrateDependency) -> AppResult<()> {
     if !Crate::valid_name(&dep.name) {
         return Err(cargo_err(&format_args!(