make closeOnChildClick default to 'a:link'

locks · locks · commit e0de9c7f6ec4 · 2019-10-26T17:03:52.000+01:00
diff --git a/app/components/rl-dropdown.js b/app/components/rl-dropdown.js
@@ -15,10 +15,8 @@ export default Component.extend({
 
   isExpanded: alias('dropdownContainer.dropdownExpanded'),
 
-  closeOnChildClick: false,
-
   click(event) {
-    let closeOnChildClick = this.closeOnChildClick;
+    let closeOnChildClick = 'a:link';
     let $target = event.target;
     let $c = this.element;
 
diff --git a/app/templates/application.hbs b/app/templates/application.hbs
@@ -40,7 +40,7 @@
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
 
-      {{#rl-dropdown tagName="ul" id="doc-links" class="dropdown" closeOnChildClick="a:link"}}
+      {{#rl-dropdown tagName="ul" id="doc-links" class="dropdown"}}
         <li><a href='https://doc.rust-lang.org/cargo/getting-started/'>Getting Started</a></li>
         <li><a href='https://doc.rust-lang.org/cargo/guide/'>Guide</a></li>
         <li><a href='https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html'>Specifying Dependencies</a></li>
@@ -66,7 +66,7 @@
           <span class='arrow'></span>
         {{/rl-dropdown-toggle}}
 
-        {{#rl-dropdown tagName="ul" class="dropdown current-user-links" closeOnChildClick="a:link"}}
+        {{#rl-dropdown tagName="ul" class="dropdown current-user-links"}}
           <li>{{#link-to 'dashboard'}}Dashboard{{/link-to}}</li>
           <li>{{#link-to 'me'}}Account Settings{{/link-to}}</li>
           <li>{{#link-to 'me.pending-invites'}}Owner Invites{{/link-to}}</li>
@@ -87,7 +87,7 @@
         Menu
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
-      {{#rl-dropdown tagName='ul' class='dropdown current-user-links' closeOnChildClick='a:link'}}
+      {{#rl-dropdown tagName='ul' class='dropdown current-user-links'}}
         <li>{{#link-to "crates"}}Browse All Crates{{/link-to}}</li>
         {{#if session.currentUser}}
           <li>{{#link-to 'dashboard'}}Dashboard{{/link-to}}</li>
diff --git a/app/templates/categories.hbs b/app/templates/categories.hbs
@@ -23,7 +23,7 @@
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
 
-      {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+      {{#rl-dropdown tagName="ul" class="dropdown"}}
         <li>
           {{#link-to (query-params sort="alpha")}}
             Alphabetical
diff --git a/app/templates/category/index.hbs b/app/templates/category/index.hbs
@@ -56,7 +56,7 @@
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
 
-      {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+      {{#rl-dropdown tagName="ul" class="dropdown"}}
         <li>
           {{#link-to (query-params sort="alpha")}}
             Alphabetical
diff --git a/app/templates/crates.hbs b/app/templates/crates.hbs
@@ -44,7 +44,7 @@
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
 
-      {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+      {{#rl-dropdown tagName="ul" class="dropdown"}}
         <li>
           {{#link-to (query-params page=1 sort="alpha")}}
             Alphabetical
diff --git a/app/templates/keyword/index.hbs b/app/templates/keyword/index.hbs
@@ -24,7 +24,7 @@
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
 
-      {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+      {{#rl-dropdown tagName="ul" class="dropdown"}}
         <li>
           {{#link-to (query-params sort="alpha")}}
             Alphabetical
diff --git a/app/templates/keywords.hbs b/app/templates/keywords.hbs
@@ -23,7 +23,7 @@
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
 
-      {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+      {{#rl-dropdown tagName="ul" class="dropdown"}}
         <li>
           {{#link-to (query-params sort="alpha")}}
             Alphabetical
diff --git a/app/templates/me/crates.hbs b/app/templates/me/crates.hbs
@@ -25,7 +25,7 @@
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
 
-      {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+      {{#rl-dropdown tagName="ul" class="dropdown"}}
         <li>
           {{#link-to (query-params sort="alpha")}}
             Alphabetical
diff --git a/app/templates/me/following.hbs b/app/templates/me/following.hbs
@@ -23,7 +23,7 @@
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
 
-      {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+      {{#rl-dropdown tagName="ul" class="dropdown"}}
         <li>
           {{#link-to (query-params sort="alpha")}}
             Alphabetical
diff --git a/app/templates/search.hbs b/app/templates/search.hbs
@@ -36,7 +36,7 @@
           <span class='arrow'></span>
         {{/rl-dropdown-toggle}}
 
-        {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+        {{#rl-dropdown tagName="ul" class="dropdown"}}
           <li>
             {{#link-to (query-params page=1 sort="relevance")}}
               Relevance
diff --git a/app/templates/team.hbs b/app/templates/team.hbs
@@ -39,7 +39,7 @@
             <span class='arrow'></span>
           {{/rl-dropdown-toggle}}
 
-          {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+          {{#rl-dropdown tagName="ul" class="dropdown"}}
             <li>
               {{#link-to (query-params sort="alpha")}}
                 Alphabetical
diff --git a/app/templates/user.hbs b/app/templates/user.hbs
@@ -30,7 +30,7 @@
             <span class='arrow'></span>
           {{/rl-dropdown-toggle}}
 
-          {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+          {{#rl-dropdown tagName="ul" class="dropdown"}}
             <li>
               {{#link-to (query-params sort="alpha")}}
                 Alphabetical
