Skip to content

Commit e110495

Browse files
committed
Remplace 32x32 PNG with SVG for GitHub mark
The PNG looks blurry on a high-resolution display. This SVG is extracted with Inkscape from GitHub-Mark.ai from https://github.com/logos.
1 parent b4d49ac commit e110495

File tree

6 files changed

+14
-4
lines changed

6 files changed

+14
-4
lines changed

app/templates/team.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
</h2>
1212
</div>
1313
{{#user-link user=model.team data-test-github-link=true}}
14-
<img alt="GitHub profile" title="GitHub profile" src="/assets/GitHub-Mark-32px.png"/>
14+
<img alt="GitHub profile" title="GitHub profile" src="/assets/GitHub-Mark.svg"/>
1515
{{/user-link}}
1616
</div>
1717
</div>

app/templates/user.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
{{ model.user.login }}
55
</h1>
66
{{#user-link user=model.user data-test-user-link=true}}
7-
<img alt="GitHub profile" title="GitHub profile" src="/assets/GitHub-Mark-32px.png"/>
7+
<img alt="GitHub profile" title="GitHub profile" src="/assets/GitHub-Mark.svg"/>
88
{{/user-link}}
99
</div>
1010

public/assets/GitHub-Mark-32px.png

-1.67 KB
Binary file not shown.

public/assets/GitHub-Mark.svg

Lines changed: 10 additions & 0 deletions
Loading

tests/acceptance/team-page-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ test('github link has image in team header', async function(assert) {
2828
await visit('/teams/github:org:thehydroimpulse');
2929

3030
assert.dom('[data-test-heading] [data-test-github-link] img')
31-
.hasAttribute('src', '/assets/GitHub-Mark-32px.png');
31+
.hasAttribute('src', '/assets/GitHub-Mark.svg');
3232
});
3333

3434
test('team organization details has github profile icon', async function(assert) {

tests/acceptance/user-page-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ test('github link has image in user header', async function(assert) {
2727
await visit('/users/thehydroimpulse');
2828

2929
assert.dom('[data-test-heading] [data-test-user-link] img')
30-
.hasAttribute('src', '/assets/GitHub-Mark-32px.png');
30+
.hasAttribute('src', '/assets/GitHub-Mark.svg');
3131
});
3232

3333
test('user details has github profile icon', async function(assert) {

0 commit comments

Comments
 (0)