Skip to content

Commit f761ca3

Browse files
committed
Move google jsapi initializer to component
This is in preparation for FastBoot. `didInsertElement` is not run when rendering in FastBoot, so it’s fine to access `Ember.$`.
1 parent 24ccc0d commit f761ca3

File tree

3 files changed

+16
-18
lines changed

3 files changed

+16
-18
lines changed

app/components/google-jsapi.js

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
import Ember from 'ember';
2+
3+
export default Ember.Component.extend({
4+
didInsertElement() {
5+
Ember.$.getScript('https://www.google.com/jsapi', function() {
6+
window.google.load('visualization', '1.0', {
7+
packages: ['corechart'],
8+
callback() {
9+
window.googleChartsLoaded = true;
10+
Ember.$(document).trigger('googleChartsLoaded');
11+
}
12+
});
13+
});
14+
}
15+
});

app/initializers/google.js

Lines changed: 0 additions & 18 deletions
This file was deleted.

app/templates/application.hbs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{{title "Cargo: packages for Rust" separator=' - ' prepend=true}}
2+
{{google-jsapi}}
23

34
<a href='https://github.com/rust-lang/crates.io' class='fork-me'>
45
<img src='/assets/forkme.png'/>

0 commit comments

Comments
 (0)