Skip to content

Commit fc6fc8c

Browse files
committed
templates/category: Use test-selectors
1 parent d6f89c8 commit fc6fc8c

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

app/templates/categories.hbs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,18 +6,18 @@
66
</div>
77

88
<div id='results'>
9-
<div class='nav'>
9+
<div class='nav' data-test-categories-nav>
1010
<span class='amt small'>
1111
Displaying
1212
<span class='cur'>{{ currentPageStart }}-{{ currentPageEnd }}</span>
1313
of <span class='total'>{{ totalItems }}</span> total results
1414
</span>
1515
</div>
1616

17-
<div class='sort'>
17+
<div class='sort' data-test-categories-sort>
1818
<span class='small'>Sort by</span>
1919
{{#rl-dropdown-container class="dropdown-container"}}
20-
{{#rl-dropdown-toggle tagName="a" class="dropdown"}}
20+
{{#rl-dropdown-toggle tagName="a" class="dropdown" data-test-current-order=true}}
2121
{{svg-jar "sort"}}
2222
{{ currentSortBy }}
2323
<span class='arrow'></span>
@@ -41,11 +41,11 @@
4141

4242
<div class='white-rows'>
4343
{{#each model as |category|}}
44-
<div class='row'>
44+
<div class='row' data-test-category={{category.slug}}>
4545
<div class='desc'>
4646
<div class='info'>
4747
{{link-to category.category "category" category.slug}}
48-
<span class='small'>
48+
<span class='small' data-test-crate-count>
4949
{{ pluralize (format-num category.crates_cnt) "crate" }}
5050
</span>
5151
</div>

app/templates/category/index.hbs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,18 @@
3636

3737
<h2>Crates</h2>
3838
<div id='results'>
39-
<div class='nav'>
39+
<div class='nav' data-test-category-nav>
4040
<span class='amt small'>
4141
Displaying
4242
<span class='cur'>{{ currentPageStart }}-{{ currentPageEnd }}</span>
4343
of <span class='total'>{{ totalItems }}</span> total results
4444
</span>
4545
</div>
4646

47-
<div class='sort'>
47+
<div class='sort' data-test-category-sort>
4848
<span class='small'>Sort by</span>
4949
{{#rl-dropdown-container class="dropdown-container"}}
50-
{{#rl-dropdown-toggle tagName="a" class="dropdown"}}
50+
{{#rl-dropdown-toggle tagName="a" class="dropdown" data-test-current-order=true}}
5151
{{svg-jar "sort"}}
5252
{{ currentSortBy }}
5353
<span class='arrow'></span>

tests/acceptance/categories-test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@ test('listing categories', async function(assert) {
1010

1111
await visit('/categories');
1212

13-
assert.dom('.desc .info span', find('.row').get(0)).hasText('0 crates');
14-
assert.dom('.desc .info span', find('.row').get(1)).hasText('1 crate');
15-
assert.dom('.desc .info span', find('.row').get(2)).hasText('3,910 crates');
13+
assert.dom('[data-test-category="api-bindings"] [data-test-crate-count]').hasText('0 crates');
14+
assert.dom('[data-test-category="algorithms"] [data-test-crate-count]').hasText('1 crate');
15+
assert.dom('[data-test-category="asynchronous"] [data-test-crate-count]').hasText('3,910 crates');
1616
});
1717

1818
test('category/:category_id index default sort is recent-downloads', async function(assert) {
1919
server.create('category', { category: 'Algorithms', crates_cnt: 1 });
2020

2121
await visit('/categories/algorithms');
2222

23-
assert.dom('div.sort div.dropdown-container a.dropdown').hasText('Recent Downloads');
23+
assert.dom('[data-test-category-sort] [data-test-current-order]').hasText('Recent Downloads');
2424
});

0 commit comments

Comments
 (0)