Tests to ensure datetime JSON serialization stays the same #1222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99c459b fixed the serialization to be RFC3339 compliant with the timezone being represented as `+00:00`. This simply adds tests for the structs where we use `#[serde(with = "::util::rfc3339")]` to ensure the JSON representation of those dates stay the same. Fixes rust-lang#1164
|
It strikes me that we may want to broaden the scope and make tests for the serialized structures to ensure the entire JSON representation stays stable over time. This just targets the dates however. |
|
Thanks, this is a good start!! ❤️ bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Jan 25, 2018
1222: Tests to ensure datetime JSON serialization stays the same r=carols10cents 99c459b fixed the serialization to be RFC3339 compliant with the timezone being represented as `+00:00`. This simply adds tests for the structs where we use `#[serde(with = "::util::rfc3339")]` to ensure the JSON representation of those dates stay the same. Fixes #1164
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
99c459b fixed the serialization to be RFC3339 compliant with the
timezone being represented as
+00:00. This simply adds tests for thestructs where we use
#[serde(with = "::util::rfc3339")]to ensurethe JSON representation of those dates stay the same.
Fixes #1164