Skip to content

Make crates.io compatible with whatsdeployed.io #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

notriddle
Copy link
Contributor

No description provided.

@jtgeibel
Copy link
Member

jtgeibel commented Dec 6, 2018

Thanks @notriddle! A very minor nit, but would you mind updating this to get rid of the clones and squashing into a single commit? Something like:

    #[derive(Serialize)]
    struct R<'a> {
        deployed_sha: &'a str,
        commit: &'a str,
    }
    Ok(req.json(&R {
        deployed_sha: &deployed_sha,
        commit: &deployed_sha,
    }))

@notriddle
Copy link
Contributor Author

Done.

@jtgeibel
Copy link
Member

jtgeibel commented Dec 6, 2018

Awesome, thanks!

@jtgeibel
Copy link
Member

jtgeibel commented Dec 6, 2018

bors: r+

bors-voyager bot added a commit that referenced this pull request Dec 6, 2018
1568: Make crates.io compatible with whatsdeployed.io r=jtgeibel a=notriddle



Co-authored-by: Michael Howell <[email protected]>
@bors-voyager
Copy link
Contributor

bors-voyager bot commented Dec 7, 2018

Build succeeded

@bors-voyager bors-voyager bot merged commit e75c292 into rust-lang:master Dec 7, 2018
@notriddle notriddle deleted the patch-1 branch December 7, 2018 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants