Skip to content

Revert "Auto merge of #1618 - jtgeibel:conduit-hyper-round2, r=sgrif" #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2019

Conversation

sgrif
Copy link
Contributor

@sgrif sgrif commented Feb 22, 2019

This reverts commit 69368a6, reversing
changes made to 6fa8ad3.

When deploying this change, we saw response times nearly triple, and our
CPU usage went through the roof. Additionally, this did not appear to
fix the memory issues we were hoping to address by removing civet.

/cc @jtgeibel

… r=sgrif"

This reverts commit 69368a6, reversing
changes made to 6fa8ad3.

When deploying this change, we saw response times nearly triple, and our
CPU usage went through the roof. Additionally, this did not appear to
fix the memory issues we were hoping to address by removing civet.
@sgrif
Copy link
Contributor Author

sgrif commented Feb 22, 2019

screen shot 2019-02-22 at 1 18 28 pm

screen shot 2019-02-22 at 1 18 31 pm

@sgrif
Copy link
Contributor Author

sgrif commented Feb 22, 2019

Note: I do think there's a possibility that we just had bad luck with noisy neighbors, and I do want to try deploying this again one more time when I can be around to keep an eye on it, but I'd like to get it off master so we don't block things until then

@sgrif sgrif requested a review from jtgeibel February 23, 2019 21:47
@jtgeibel
Copy link
Member

I do think there's a possibility that we just had bad luck with noisy neighbors

That's definitely a possibility. I had done some load/concurrently testing of some API endpoints and didn't see any noticeable difference in requests per second before and after the change. However, I was only looking at RPS, not response time for individual requests and I'm now wondering if I was just effectively load testing the database. I'll also do some load testing of non-API endpoints to see if serving the static ember HTML is impacted.

I agree, lets revert for now to keep master deployable.

@bors r+

@bors
Copy link
Contributor

bors commented Feb 23, 2019

📌 Commit d19d2d4 has been approved by jtgeibel

@bors
Copy link
Contributor

bors commented Feb 23, 2019

⌛ Testing commit d19d2d4 with merge a0b36cd...

bors added a commit that referenced this pull request Feb 23, 2019
Revert "Auto merge of #1618 - jtgeibel:conduit-hyper-round2, r=sgrif"

This reverts commit 69368a6, reversing
changes made to 6fa8ad3.

When deploying this change, we saw response times nearly triple, and our
CPU usage went through the roof. Additionally, this did not appear to
fix the memory issues we were hoping to address by removing civet.

/cc @jtgeibel
@sgrif
Copy link
Contributor Author

sgrif commented Feb 23, 2019

👍 I'm also fine just trying again as is later this week, just need to do it when I have some time to be around

@bors
Copy link
Contributor

bors commented Feb 23, 2019

☀️ Test successful - checks-travis
Approved by: jtgeibel
Pushing a0b36cd to master...

@bors bors merged commit d19d2d4 into rust-lang:master Feb 23, 2019
@sgrif sgrif deleted the sg-revert-hyper branch March 9, 2019 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants