Don't consider versions with build metadata to be unstable #1835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jtgeibel (rust_highfive has picked a reviewer for you, use r? to override) |
Our backend was behaving properly in this regard, but the front end was considering any version that had build metadata to be unstable. There's no reason for us to have this detection be hand-rolled, we can use a proper semver library to determine whether something is a prerelease or not.
sgrif
force-pushed
the
sg-proper-prerelease-checking
branch
from
a4fbaa7 to
7c3ff21
Compare
locks
approved these changes
Sep 11, 2019
|
@bors r=locks |
|
📌 Commit 7c3ff21 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 11, 2019
Don't consider versions with build metadata to be unstable Our backend was behaving properly in this regard, but the front end was considering any version that had build metadata to be unstable. There's no reason for us to have this detection be hand-rolled, we can use a proper semver library to determine whether something is a prerelease or not. I've manually confirmed this has the expected behavior for the crate `openssl-src`, which was reported with incorrect behavior.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our backend was behaving properly in this regard, but the front end was
considering any version that had build metadata to be unstable. There's
no reason for us to have this detection be hand-rolled, we can use a
proper semver library to determine whether something is a prerelease or
not.
I've manually confirmed this has the expected behavior for the crate
openssl-src, which was reported with incorrect behavior.