Add indexes in migrations that have already been running in production #1844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@sgrif added these to the production database by hand for testing purposes a while back; they seem to be performing well so they should get added to the codebase to keep the schema in sync.
|
Both indexes look good, the brin index is way lossier than I'd like, but it's still providing some value and is basically free. |
|
ok, so is this good to r+? |
|
@bors r+ |
|
📌 Commit c4db34c has been approved by |
bors
added a commit
that referenced
this pull request
Nov 2, 2019
…carols10cents Add indexes in migrations that have already been running in production @sgrif added these to the production database by hand for testing purposes a while back; they seem to be performing well so they should get added to the codebase to keep the schema in sync. r? @sgrif, feel free to wait to merge this until you've checked the bloat you mentioned wanting to check; I'm happy to update this PR if needed. Just wanted to have something around as a reminder.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sgrif added these to the production database by hand for testing
purposes a while back; they seem to be performing well so they should
get added to the codebase to keep the schema in sync.
r? @sgrif, feel free to wait to merge this until you've checked the bloat you mentioned wanting to check; I'm happy to update this PR if needed. Just wanted to have something around as a reminder.