Make crate-readme component scroll to URL fragment if specified #1848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jtgeibel (rust_highfive has picked a reviewer for you, use r? to override) |
|
I have a small change I want to make today before merging! |
|
If we manage to get Fastboot working, we won't need this anymore. (I'm not saying we shouldn't do this, since it is unclear whether and when we will get Fastboot working in prod.) |
|
Code updated and ready for review and merge! |
|
@smarnach confirm, we'll need to either remove this code or have an extra check for fastboot because of the |
|
@bors: r+ |
|
📌 Commit 02562c2 has been approved by |
bors
added a commit
that referenced
this pull request
Sep 24, 2019
Make crate-readme component scroll to URL fragment if specified Fixes #1847
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1847