Check that URLs begin with http:// or https://
#1898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually it would be nice to return a vec of errors, to report if multiple URLs fail. In that case we could add additional examples of relative URLs and ensure that all 3 URLs fail validation. For now, the test focuses only on the condition that is currently failing. Refs: rust-lang#169
This switches to a manual check of the string prefix, because `Url::parse` may sanitize URLs as they are parsed, making it difficult to ensure both slashes are present. Fixes: rust-lang#169
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
This looks good to me. @bors r+ |
|
📌 Commit b46821b has been approved by |
bors
added a commit
that referenced
this pull request
Nov 17, 2019
Check that URLs begin with `http://` or `https://` This switches to a manual check of the string prefix, because `Url::parse` may sanitize URLs as they are parsed, making it difficult to ensure both slashes are present. Fixes: #169
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches to a manual check of the string prefix, because
Url::parsemay sanitize URLs as they are parsed, making itdifficult to ensure both slashes are present.
Fixes: #169