-
Notifications
You must be signed in to change notification settings - Fork 648
Improve Mirage setup #2386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improve Mirage setup #2386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that `user` records are always sent to the network layer with a numeric `id` value
This ensures that `team` records are always sent to the network layer with a numeric `id` value
These are always removed by the serializer for now because they should only be visible to the authenticated user himself
9f72ebd
to
6e56c8e
Compare
@bors r+ |
📌 Commit a610bcf has been approved by |
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-frontend 🐹
C-internal 🔧
Category: Nonessential work that would make the codebase more consistent or clear
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves our "fake backend" setup which uses https://www.ember-cli-mirage.com/
Due to the number of changes this PR is likely best reviewed commit-by-commit.
The main change is that this PR will make it easier to simulate the logged-in state of the application by providing a relatively simple
this.authenticateAs(user)
helper method on the test contexts.r? @locks