Skip to content

Improve Mirage setup #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 2, 2020
Merged

Improve Mirage setup #2386

merged 14 commits into from
Apr 2, 2020

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 2, 2020

This PR improves our "fake backend" setup which uses https://www.ember-cli-mirage.com/

Due to the number of changes this PR is likely best reviewed commit-by-commit.

The main change is that this PR will make it easier to simulate the logged-in state of the application by providing a relatively simple this.authenticateAs(user) helper method on the test contexts.

r? @locks

@Turbo87 Turbo87 added A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Apr 2, 2020
@Turbo87 Turbo87 force-pushed the mirage branch 2 times, most recently from 9f72ebd to 6e56c8e Compare April 2, 2020 18:13
@locks
Copy link
Contributor

locks commented Apr 2, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Apr 2, 2020

📌 Commit a610bcf has been approved by locks

@bors
Copy link
Contributor

bors commented Apr 2, 2020

⌛ Testing commit a610bcf with merge 157bdb4...

@bors
Copy link
Contributor

bors commented Apr 2, 2020

☀️ Test successful - checks-travis
Approved by: locks
Pushing 157bdb4 to master...

@bors bors merged commit 157bdb4 into rust-lang:master Apr 2, 2020
@Turbo87 Turbo87 deleted the mirage branch April 3, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants