Skip to content

Convert a few components to template-only components #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2020

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 26, 2020

r? @locks

@locks
Copy link
Contributor

locks commented Apr 26, 2020

@Turbo87 can you check the Percy failure? user-link might need a tweak to preserve the spacing.

@Turbo87
Copy link
Member Author

Turbo87 commented Apr 26, 2020

looks like I forgot a ...attributes. should be fixed now.

the GitHub Actions "Backend (beta)" job currently seems flaky for unrelated reasons.

@locks
Copy link
Contributor

locks commented Apr 26, 2020

We're getting some failures I haven't investigated 🤔

@Turbo87
Copy link
Member Author

Turbo87 commented Apr 26, 2020

@locks sorry, my fault. should be fixed now!

@Turbo87 Turbo87 requested a review from locks April 30, 2020 06:05
@locks
Copy link
Contributor

locks commented Apr 30, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Apr 30, 2020

📌 Commit e7c4998 has been approved by locks

@bors
Copy link
Contributor

bors commented Apr 30, 2020

⌛ Testing commit e7c4998 with merge 8e7062b...

@bors
Copy link
Contributor

bors commented Apr 30, 2020

☀️ Test successful - checks-travis
Approved by: locks
Pushing 8e7062b to master...

@bors bors merged commit 8e7062b into rust-lang:master Apr 30, 2020
@Turbo87 Turbo87 deleted the template-only branch April 30, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants