Use nodejs buildpack directly (instead of via the emberjs buildpack) #2806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since rust-lang#2657 we build the frontend twice during a deploy. It seems that the nodejs buildpack (pulled in by the emberjs buildpack) is running our build script so lets just depend on that directly because it is actively supported by Heroku.
|
This also appears to drop the size of the compiled slug from ~270M to ~90M! |
JohnTitor
approved these changes
Sep 20, 2020
|
@bors r+ |
|
📌 Commit 2307bd6 has been approved by |
|
☀️ Test successful - checks-travis |
Strangely, I did not observe a similar drop on staging. I looked into some recent deploys, more info in #2809. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #2657 we build the frontend twice during a deploy. It seems that
the nodejs buildpack (pulled in by the emberjs buildpack) is running
our build script so lets just depend on that directly because it is
actively supported by Heroku.
r? @JohnTitor