Forbid token auth on /me endpoint
#3518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe we previously had to do authentication at the start of the endpoint because the database connection was obtained early and there are lifetime issues around using the `req` value while holding a database connection. This avoids authenticating the user (and possibly updating last_used_at for API tokens) unless the search query requires it.
|
Are we sure that cargo is not using |
Turbo87
added
A-backend ⚙️
C-internal 🔧
|
@bors r+ |
|
📌 Commit 5e4f286 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prohibits access to the
/api/v1/meendpoint via an API token. I'd like to merge and deploy this before moving forward on rust-lang/simpleinfra#43, which would expose this endpoint. (Previous lockdown work was done in #3470.)The second commit ensure that the user is only authenticated on the search endpoint when querying for followed crates.
r? @pietroalbini