Address clippy findings #3715
Merged
Address clippy findings #3715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.53.0 is to be released tomorrow, and currently has a clippy regression that causes an ICE. https://internals.rust-lang.org/t/1-53-0-prerelease-testing/14884/2?u=jtgeibel
Turbo87
added
A-backend ⚙️
C-internal 🔧
|
looks great, thanks! :) @bors r+ |
|
📌 Commit d5471df has been approved by |
|
also, thanks for the detailed commit list. makes it much easier to review :) |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses warnings identified by clippy. Some of these warnings are currently generated on stable, but a missing environment variable caused those warnings to be logged but not to fail the build. The next to last commit fixes this.
This final commit pins to 1.52.1 for linting, until a compiler ICE in 1.53.0 is addressed. I've just reported this ICE against the pre-release, but it may be too late to address in 1.53.0.
r? @Turbo87