Use sentry-conduit middleware for error reporting
#3988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Turbo87
force-pushed
the
sentry-conduit
branch
3 times, most recently
from
a268a81 to
fa6a112
Compare
This tracks how many sessions ended up with errors vs. how many succeeded per deployed release.
Turbo87
force-pushed
the
sentry-conduit
branch
from
fa6a112 to
c6c63f1
Compare
|
Nice clean up! @bors r+ |
|
📌 Commit c6c63f1 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of this crate is largely based on the Sentry middleware code in crates.io and the implementation of sentry-actix. It has several advantages over the implementation that we currently use:
transactionfield support (aka. the route pattern that was used by conduit-router)see https://github.com/Turbo87/sentry-conduit