router: Set Sentry transaction field before calling the request handler
#4015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
the
C-internal 🔧
…dler This disables the `router` feature of `sentry-conduit` and instead calls `set_transaction()` of Sentry manually before calling the route handler itself. This has the advantage of also adding the `transaction` field to Sentry issues that are not reported by the `sentry-conduit` middleware itself.
Turbo87
force-pushed
the
sentry-transaction
branch
from
6da05e1 to
c6f8c09
Compare
|
closing in favor of #4036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the
routerfeature ofsentry-conduitand instead callsset_transaction()of Sentry manually before calling the route handler itself. This has the advantage of also adding thetransactionfield to Sentry issues that are not reported by thesentry-conduitmiddleware itself.