Skip to content

Ensure the HEAD for test indexes is "master" #4017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

pietroalbini
Copy link
Member

Different versions of git2 in different systems use a different name for
the HEAD branch they create, switching between "master" and "main". This
causes test failures when they pick "main", as the rest of crates.io
assumes the branch is named "master".

This commit changes the HEAD name during tests to always be "master",
allowing the test suite to work everywhere without breakages.

Refactoring the application not to care about the branch name will be
done in a future commit, this just focuses on unbreaking the test suite.

Different versions of git2 in different systems use a different name for
the HEAD branch they create, switching between "master" and "main". This
causes test failures when they pick "main", as the rest of crates.io
assumes the branch is named "master".

This commit changes the HEAD name during tests to always be "master",
allowing the test suite to work everywhere without breakages.

Refactoring the application not to care about the branch name will be
done in a future commit, this just focuses on unbreaking the test suite.
@pietroalbini pietroalbini requested a review from Turbo87 October 15, 2021 12:19
Copy link
Member

@Turbo87 Turbo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

feel free to r=me once CI is 🍏

@Turbo87 Turbo87 added A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Oct 15, 2021
@Turbo87
Copy link
Member

Turbo87 commented Oct 15, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Oct 15, 2021

📌 Commit 77aec72 has been approved by Turbo87

@bors
Copy link
Contributor

bors commented Oct 15, 2021

⌛ Testing commit 77aec72 with merge a74e148...

@bors
Copy link
Contributor

bors commented Oct 15, 2021

☀️ Test successful - checks-actions
Approved by: Turbo87
Pushing a74e148 to master...

@bors bors merged commit a74e148 into rust-lang:master Oct 15, 2021
@pietroalbini pietroalbini deleted the ensure-test-git-index-branch branch October 15, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants