Replace computed properties with macro-decorators
#4068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
A-frontend 🐹
C-internal 🔧
Mikek2252
approved these changes
Oct 21, 2021
|
@bors r=Mikek2252 thank you! :) |
|
📌 Commit c9ef47c has been approved by |
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Oct 22, 2021
ESLint: Enable computed property rules With #4068 we can finally enable these rules now 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://pzuraq.github.io/macro-decorators/
This has basically the same API as
@ember/object/computedbut relies on tracked properties underneath, which should result in a small performance improvement.