Skip to content

Fix flaky tests #8449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Fix flaky tests #8449

merged 1 commit into from
Apr 11, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 11, 2024

It looks like the pool.timeout_get() fn does not actually retry connecting until the timeout is elapsed and instead fails instantly. this PR changes the wait_until_healthy() fn to retry connecting in a loop until the timeout is elapsed. I ran the CI pipeline multiple times with this change and wasn't able to trigger the failing tests anymore, so hopefully this fixes the flaky tests.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.64%. Comparing base (1af5ce3) to head (e8083ef).

❗ Current head e8083ef differs from pull request most recent head 6bb0b15. Consider uploading reports for the commit 6bb0b15 to get more accurate results

Files Patch % Lines
src/tests/unhealthy_database.rs 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8449      +/-   ##
==========================================
- Coverage   87.65%   87.64%   -0.01%     
==========================================
  Files         272      272              
  Lines       26193    26202       +9     
==========================================
+ Hits        22959    22966       +7     
- Misses       3234     3236       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Turbo87 Turbo87 marked this pull request as ready for review April 11, 2024 09:35
@Turbo87 Turbo87 enabled auto-merge (squash) April 11, 2024 09:36
@Turbo87 Turbo87 merged commit 81df0a7 into rust-lang:main Apr 11, 2024
@Turbo87 Turbo87 deleted the flaky-tests branch April 11, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant