remove pub where possible

Author: jyn514

src/db/file.rs

@@ -42,7 +42,7 @@ fn get_file_list_from_dir<P: AsRef<Path>>(path: P,
 }
 
 
-pub fn get_file_list<P: AsRef<Path>>(path: P) -> Result<Vec<PathBuf>> {
+fn get_file_list<P: AsRef<Path>>(path: P) -> Result<Vec<PathBuf>> {
     let path = path.as_ref();
     let mut files = Vec::new();
 

src/docbuilder/metadata.rs

@@ -53,7 +53,7 @@ pub struct Metadata {
     /// System dependencies.
     ///
     /// Docs.rs is running on a Debian jessie.
-    pub dependencies: Option<Vec<String>>,
+    dependencies: Option<Vec<String>>,
 }
 
 
@@ -69,7 +69,7 @@ impl Metadata {
         Err(err_msg("Manifest not found"))
     }
 
-    pub fn from_manifest<P: AsRef<Path>>(path: P) -> Metadata {
+    fn from_manifest<P: AsRef<Path>>(path: P) -> Metadata {
         use std::fs::File;
         use std::io::Read;
         let mut f = match File::open(path) {

src/utils/github_updater.rs

@@ -9,11 +9,11 @@ use failure::err_msg;
 /// Fields we need use in cratesfyi
 #[derive(Debug)]
 struct GitHubFields {
-    pub description: String,
-    pub stars: i64,
-    pub forks: i64,
-    pub issues: i64,
-    pub last_commit: time::Timespec,
+    description: String,
+    stars: i64,
+    forks: i64,
+    issues: i64,
+    last_commit: time::Timespec,
 }
 
 

src/web/mod.rs

@@ -1,7 +1,7 @@
 //! Web interface of cratesfyi
 
 
-pub mod page;
+pub(crate) mod page;
 
 /// ctry! (cratesfyitry) is extremely similar to try! and itry!
 /// except it returns an error page response instead of plain Err.
@@ -45,7 +45,7 @@ mod builds;
 mod error;
 mod sitemap;
 mod routes;
-pub mod metrics;
+pub(crate) mod metrics;
 
 use std::{env, fmt};
 use std::error::Error;
@@ -105,7 +105,7 @@ impl CratesfyiHandler {
         chain
     }
 
-    pub fn new(pool_factory: PoolFactory) -> CratesfyiHandler {
+    fn new(pool_factory: PoolFactory) -> CratesfyiHandler {
         let routes = routes::build_routes();
         let blacklisted_prefixes = routes.page_prefixes();
 
@@ -201,7 +201,7 @@ enum MatchVersion {
 impl MatchVersion {
     /// Convert this `MatchVersion` into an `Option`, discarding whether the matched version came
     /// from an exact version number or a semver requirement.
-    pub fn into_option(self) -> Option<String> {
+    fn into_option(self) -> Option<String> {
         match self {
             MatchVersion::Exact(v) | MatchVersion::Semver(v) => Some(v),
             MatchVersion::None => None,
@@ -396,7 +396,7 @@ fn redirect(url: Url) -> Response {
     resp
 }
 
-pub fn redirect_base(req: &Request) -> String {
+fn redirect_base(req: &Request) -> String {
     // Try to get the scheme from CloudFront first, and then from iron
     let scheme = req.headers
         .get_raw("cloudfront-forwarded-proto")
@@ -449,18 +449,18 @@ fn ico_handler(req: &mut Request) -> IronResult<Response> {
 
 /// MetaData used in header
 #[derive(Debug)]
-pub struct MetaData {
-    pub name: String,
-    pub version: String,
-    pub description: Option<String>,
-    pub target_name: Option<String>,
-    pub rustdoc_status: bool,
-    pub default_target: String,
+struct MetaData {
+    name: String,
+    version: String,
+    description: Option<String>,
+    target_name: Option<String>,
+    rustdoc_status: bool,
+    default_target: String,
 }
 
 
 impl MetaData {
-    pub fn from_crate(conn: &Connection, name: &str, version: &str) -> Option<MetaData> {
+    fn from_crate(conn: &Connection, name: &str, version: &str) -> Option<MetaData> {
         for row in &conn.query("SELECT crates.name,
                                        releases.version,
                                        releases.description,

src/web/releases.rs

@@ -330,7 +330,7 @@ pub fn releases_feed_handler(req: &mut Request) -> IronResult<Response> {
 }
 
 
-pub fn releases_handler(packages: Vec<Release>,
+fn releases_handler(packages: Vec<Release>,
                         page_number: i64,
                         release_type: &str,
                         tab: &str,

src/web/rustdoc.rs

@@ -23,14 +23,14 @@ use utils;
 
 #[derive(Debug)]
 struct RustdocPage {
-    pub head: String,
-    pub body: String,
-    pub body_class: String,
-    pub name: String,
-    pub full: String,
-    pub version: String,
-    pub description: Option<String>,
-    pub crate_details: Option<CrateDetails>,
+    head: String,
+    body: String,
+    body_class: String,
+    name: String,
+    full: String,
+    version: String,
+    description: Option<String>,
+    crate_details: Option<CrateDetails>,
 }
 
 

src/web/source.rs

@@ -82,7 +82,7 @@ impl FileList {
     /// This function is only returning FileList for requested directory. If is empty,
     /// it will return list of files (and dirs) for root directory. req_path must be a
     /// directory or empty for root directory.
-    pub fn from_path(conn: &Connection,
+    fn from_path(conn: &Connection,
                      name: &str,
                      version: &str,
                      req_path: &str)