* pecoff.c (coff_add): Another memcpy -> coff_read4 fix.

ianlancetaylor · ianlancetaylor · commit 97dd0dfa9ea0 · 2018-01-25T07:34:02.000-08:00
Updates ianlancetaylor#11
diff --git a/pecoff.c b/pecoff.c
@@ -631,10 +631,10 @@ coff_add (struct backtrace_state *state, int descriptor,
     goto fail;
 
   {
-    const char *vptr = (const char *)fhdr_view.data;
+    const unsigned char *vptr = fhdr_view.data;
 
     if (vptr[0] == 'M' && vptr[1] == 'Z')
-      memcpy (&fhdr_off, vptr + 0x3c, 4);
+      fhdr_off = coff_read4 (vptr + 0x3c);
     else
       fhdr_off = 0;
   }

Original file line number	Diff line number	Diff line change
`@@ -631,10 +631,10 @@ coff_add (struct backtrace_state *state, int descriptor,`
`631`	`631`	`goto fail;`
`632`	`632`
`633`	`633`	`{`
`634`		`- const char vptr = (const char )fhdr_view.data;`
	`634`	`+ const unsigned char *vptr = fhdr_view.data;`
`635`	`635`
`636`	`636`	`if (vptr[0] == 'M' && vptr[1] == 'Z')`
`637`		`- memcpy (&fhdr_off, vptr + 0x3c, 4);`
	`637`	`+ fhdr_off = coff_read4 (vptr + 0x3c);`
`638`	`638`	`else`
`639`	`639`	`fhdr_off = 0;`
`640`	`640`	`}`