Skip to content

Commit 02bf563

Browse files
committed
Fix swig scripts install target name
LLVM install component targets needs to be in the form of: install-{target}[-stripped] I tested with: ``` cmake ... -DLLVM_ENABLE_PROJECTS="clang;lldb" -DLLVM_DISTRIBUTION_COMPONENTS="lldb;liblldb;lldb-python-scripts;" ... DESTDIR=... ninja install-distribution ``` @JDevlieghere `finish_swig_python_scripts` is a really weird name for a distribution component, any reason that it has to be this way? Differential Revision: https://reviews.llvm.org/D86235
1 parent 196e6f9 commit 02bf563

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

lldb/bindings/python/CMakeLists.txt

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -163,17 +163,17 @@ function(finish_swig_python swig_target lldb_python_bindings_dir lldb_python_tar
163163
string(REPLACE ${CMAKE_CFG_INTDIR} "\$\{CMAKE_INSTALL_CONFIG_NAME\}" LLDB_PYTHON_INSTALL_PATH ${LLDB_PYTHON_INSTALL_PATH})
164164
string(REPLACE ${CMAKE_CFG_INTDIR} "\$\{CMAKE_INSTALL_CONFIG_NAME\}" lldb_python_target_dir ${lldb_python_target_dir})
165165
endif()
166-
set(swig_scripts_target "${swig_target}_scripts")
167-
set(swig_scripts_install_target "${swig_target}_scripts_install")
168-
add_custom_target(${swig_scripts_target})
169-
add_dependencies(${swig_scripts_target} ${swig_target})
166+
set(python_scripts_target "lldb-python-scripts")
167+
set(python_scripts_install_target "install-${python_scripts_target}")
168+
add_custom_target(${python_scripts_target})
169+
add_dependencies(${python_scripts_target} ${swig_target})
170170
install(DIRECTORY ${lldb_python_target_dir}/../
171171
DESTINATION ${LLDB_PYTHON_INSTALL_PATH}
172-
COMPONENT ${swig_scripts_target})
172+
COMPONENT ${python_scripts_target})
173173
if (NOT LLVM_ENABLE_IDE)
174-
add_llvm_install_targets(${swig_scripts_install_target}
175-
COMPONENT ${swig_scripts_target}
176-
DEPENDS ${swig_scripts_target})
174+
add_llvm_install_targets(${python_scripts_install_target}
175+
COMPONENT ${python_scripts_target}
176+
DEPENDS ${python_scripts_target})
177177
endif()
178178

179179
# Add a Post-Build Event to copy the custom Python DLL to the lldb binaries dir so that Windows can find it when launching

0 commit comments

Comments
 (0)