Skip to content

Commit 2819cea

Browse files
committed
Revert "[HIP] Fix -gsplit-dwarf option"
This reverts commit e50465e due to regression in lldb tests.
1 parent e50465e commit 2819cea

File tree

6 files changed

+7
-41
lines changed

6 files changed

+7
-41
lines changed

clang/lib/Driver/ToolChains/Clang.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4810,7 +4810,7 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
48104810
(isa<AssembleJobAction>(JA) || isa<CompileJobAction>(JA) ||
48114811
isa<BackendJobAction>(JA));
48124812
if (SplitDWARF) {
4813-
const char *SplitDWARFOut = SplitDebugName(JA, Args, Input, Output);
4813+
const char *SplitDWARFOut = SplitDebugName(Args, Input, Output);
48144814
CmdArgs.push_back("-split-dwarf-file");
48154815
CmdArgs.push_back(SplitDWARFOut);
48164816
if (DwarfFission == DwarfFissionKind::Split) {
@@ -7047,7 +7047,7 @@ void ClangAs::ConstructJob(Compilation &C, const JobAction &JA,
70477047
if (getDebugFissionKind(D, Args, A) == DwarfFissionKind::Split &&
70487048
T.isOSBinFormatELF()) {
70497049
CmdArgs.push_back("-split-dwarf-output");
7050-
CmdArgs.push_back(SplitDebugName(JA, Args, Input, Output));
7050+
CmdArgs.push_back(SplitDebugName(Args, Input, Output));
70517051
}
70527052

70537053
assert(Input.isFilename() && "Invalid input.");

clang/lib/Driver/ToolChains/CommonArgs.cpp

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -902,31 +902,22 @@ bool tools::areOptimizationsEnabled(const ArgList &Args) {
902902
return false;
903903
}
904904

905-
const char *tools::SplitDebugName(const JobAction &JA, const ArgList &Args,
906-
const InputInfo &Input,
905+
const char *tools::SplitDebugName(const ArgList &Args, const InputInfo &Input,
907906
const InputInfo &Output) {
908-
// Adds '_' and GPU arch to the stem of .dwo file for HIP, which is
909-
// expected by gdb.
910-
auto AddPostfix = [JA](auto &F) {
911-
if (JA.getOffloadingDeviceKind() == Action::OFK_HIP)
912-
F += (Twine("_") + JA.getOffloadingArch()).str();
913-
};
914907
if (Arg *A = Args.getLastArg(options::OPT_gsplit_dwarf_EQ))
915908
if (StringRef(A->getValue()) == "single")
916909
return Args.MakeArgString(Output.getFilename());
917910

918911
Arg *FinalOutput = Args.getLastArg(options::OPT_o);
919912
if (FinalOutput && Args.hasArg(options::OPT_c)) {
920-
SmallString<128> T(llvm::sys::path::stem(FinalOutput->getValue()));
921-
AddPostfix(T);
913+
SmallString<128> T(FinalOutput->getValue());
922914
llvm::sys::path::replace_extension(T, "dwo");
923915
return Args.MakeArgString(T);
924916
} else {
925917
// Use the compilation dir.
926918
SmallString<128> T(
927919
Args.getLastArgValue(options::OPT_fdebug_compilation_dir));
928920
SmallString<128> F(llvm::sys::path::stem(Input.getBaseInput()));
929-
AddPostfix(F);
930921
llvm::sys::path::replace_extension(F, "dwo");
931922
T += F;
932923
return Args.MakeArgString(F);

clang/lib/Driver/ToolChains/CommonArgs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ void AddRunTimeLibs(const ToolChain &TC, const Driver &D,
4949
llvm::opt::ArgStringList &CmdArgs,
5050
const llvm::opt::ArgList &Args);
5151

52-
const char *SplitDebugName(const JobAction &JA, const llvm::opt::ArgList &Args,
52+
const char *SplitDebugName(const llvm::opt::ArgList &Args,
5353
const InputInfo &Input, const InputInfo &Output);
5454

5555
void SplitDebugInfo(const ToolChain &TC, Compilation &C, const Tool &T,

clang/lib/Driver/ToolChains/Gnu.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -939,7 +939,7 @@ void tools::gnutools::Assembler::ConstructJob(Compilation &C,
939939
if (Args.hasArg(options::OPT_gsplit_dwarf) &&
940940
getToolChain().getTriple().isOSLinux())
941941
SplitDebugInfo(getToolChain(), C, *this, JA, Args, Output,
942-
SplitDebugName(JA, Args, Inputs[0], Output));
942+
SplitDebugName(Args, Inputs[0], Output));
943943
}
944944

945945
namespace {

clang/lib/Driver/ToolChains/MinGW.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ void tools::MinGW::Assembler::ConstructJob(Compilation &C, const JobAction &JA,
5555

5656
if (Args.hasArg(options::OPT_gsplit_dwarf))
5757
SplitDebugInfo(getToolChain(), C, *this, JA, Args, Output,
58-
SplitDebugName(JA, Args, Inputs[0], Output));
58+
SplitDebugName(Args, Inputs[0], Output));
5959
}
6060

6161
void tools::MinGW::Linker::AddLibGCC(const ArgList &Args,

clang/test/Driver/hip-gsplit-dwarf-options.hip

Lines changed: 0 additions & 25 deletions
This file was deleted.

0 commit comments

Comments
 (0)