[HWASan] Remove incorrect unreachable.

fmayer · fmayer · commit 29ff262761af · 2022-08-05T13:14:08.000-07:00
This function could be called wih access_info & 0x20 or with flags()->halt_on_error, in which case HandleTagMismatch returns (is not fatal). Reviewed By: eugenis Differential Revision: https://reviews.llvm.org/D131279
diff --git a/compiler-rt/lib/hwasan/hwasan.cpp b/compiler-rt/lib/hwasan/hwasan.cpp
@@ -232,7 +232,6 @@ void HwasanTagMismatch(uptr addr, uptr access_info, uptr *registers_frame,
 
   HandleTagMismatch(ai, (uptr)__builtin_return_address(0),
                     (uptr)__builtin_frame_address(0), nullptr, registers_frame);
-  __builtin_unreachable();
 }
 
 Thread *GetCurrentThread() {

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,6 @@ void HwasanTagMismatch(uptr addr, uptr access_info, uptr *registers_frame,`
`232`	`232`
`233`	`233`	`HandleTagMismatch(ai, (uptr)__builtin_return_address(0),`
`234`	`234`	`(uptr)__builtin_frame_address(0), nullptr, registers_frame);`
`235`		`- __builtin_unreachable();`
`236`	`235`	`}`
`237`	`236`
`238`	`237`	`Thread *GetCurrentThread() {`