Skip to content

Commit 2c629eb

Browse files
committed
[libc++][CI] Fixes error messages.
Fixes 2 error messages from the module test clang-tidy plugin. - an issue where an empty filename can't be used in an AST matcher - an issue where no filename is valid when testing the std module cppm This reduces the output of the test, making it easier to find the real error when the test fails. Reviewed By: philnik, #libc Differential Revision: https://reviews.llvm.org/D157741
1 parent 8f01029 commit 2c629eb

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

libcxx/test/tools/clang_tidy_checks/header_exportable_declarations.cpp

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,18 @@ header_exportable_declarations::header_exportable_declarations(
3838
filename_(Options.get("Filename", "")),
3939
file_type_(Options.get("FileType", header_exportable_declarations::FileType::Unknown)),
4040
extra_header_(Options.get("ExtraHeader", "")) {
41-
if (filename_.empty())
42-
llvm::errs() << "No filename is provided.\n";
43-
4441
switch (file_type_) {
4542
case header_exportable_declarations::FileType::Header:
46-
/* DO NOTHING */
43+
if (filename_.empty())
44+
llvm::errs() << "No filename is provided.\n";
45+
if (extra_header_.empty())
46+
extra_header_ = "$^"; // Use a never matching regex to silence an error message.
4747
break;
48-
case header_exportable_declarations::FileType::Module:
4948
case header_exportable_declarations::FileType::ModulePartition:
49+
if (filename_.empty())
50+
llvm::errs() << "No filename is provided.\n";
51+
[[fallthrough]];
52+
case header_exportable_declarations::FileType::Module:
5053
if (!extra_header_.empty())
5154
llvm::errs() << "Extra headers are not allowed for modules.\n";
5255
if (Options.get("SkipDeclarations"))

0 commit comments

Comments
 (0)