[lldb/Host] Fix crash in FileSystem::IsLocal

medismailben · medismailben · commit 2dc6e906b09d · 2022-02-25T18:33:31.000-08:00
This checks `m_fs` before dereferencing it to access its`isLocal` method.

rdar://67410058

Signed-off-by: Med Ismail Bennani &lt;medismail.bennani@gmail.com&gt;
diff --git a/lldb/source/Host/common/FileSystem.cpp b/lldb/source/Host/common/FileSystem.cpp
@@ -192,7 +192,8 @@ bool FileSystem::IsDirectory(const FileSpec &file_spec) const {
 
 bool FileSystem::IsLocal(const Twine &path) const {
   bool b = false;
-  m_fs->isLocal(path, b);
+  if (m_fs)
+    m_fs->isLocal(path, b);
   return b;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,8 @@ bool FileSystem::IsDirectory(const FileSpec &file_spec) const {`
`192`	`192`
`193`	`193`	`bool FileSystem::IsLocal(const Twine &path) const {`
`194`	`194`	`bool b = false;`
`195`		`- m_fs->isLocal(path, b);`
	`195`	`+ if (m_fs)`
	`196`	`+ m_fs->isLocal(path, b);`
`196`	`197`	`return b;`
`197`	`198`	`}`
`198`	`199`