Skip to content

Commit 52eab34

Browse files
committed
PDBFileBuilder: Switch to xxh3_64bits
Following recent changes switching from xxh64 to xxh32 for better hashing performance (e.g., D154813). I am not familiar with this use case, but this change will ensure that the lld executable doesn't need xxHash64 after wasm-ld migrates.
1 parent b2eda85 commit 52eab34

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ struct llvm::pdb::SymbolDenseMapInfo {
7676
return Tombstone;
7777
}
7878
static unsigned getHashValue(const CVSymbol &Val) {
79-
return xxHash64(Val.RecordData);
79+
return xxh3_64bits(Val.RecordData);
8080
}
8181
static bool isEqual(const CVSymbol &LHS, const CVSymbol &RHS) {
8282
return LHS.RecordData == RHS.RecordData;

llvm/lib/DebugInfo/PDB/Native/PDBFileBuilder.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ Error PDBFileBuilder::commit(StringRef Filename, codeview::GUID *Guid) {
340340
if (Info->hashPDBContentsToGUID()) {
341341
// Compute a hash of all sections of the output file.
342342
uint64_t Digest =
343-
xxHash64({Buffer.getBufferStart(), Buffer.getBufferEnd()});
343+
xxh3_64bits({Buffer.getBufferStart(), Buffer.getBufferEnd()});
344344

345345
H->Age = 1;
346346

0 commit comments

Comments
 (0)