[lldb/Interpreter][NFC] Replace default constructors/destructors bodies with "=default"

Author: tkrasnukha

lldb/include/lldb/Interpreter/CommandHistory.h

@@ -20,9 +20,9 @@ namespace lldb_private {
 
 class CommandHistory {
 public:
-  CommandHistory();
+  CommandHistory() = default;
 
-  ~CommandHistory();
+  ~CommandHistory() = default;
 
   size_t GetSize() const;
 

lldb/include/lldb/Interpreter/CommandObject.h

@@ -113,7 +113,7 @@ class CommandObject {
     llvm::StringRef help = "", llvm::StringRef syntax = "",
                 uint32_t flags = 0);
 
-  virtual ~CommandObject();
+  virtual ~CommandObject() = default;
 
   static const char *
   GetArgumentTypeAsCString(const lldb::CommandArgumentType arg_type);

lldb/include/lldb/Interpreter/CommandReturnObject.h

@@ -26,7 +26,7 @@ class CommandReturnObject {
 public:
   CommandReturnObject(bool colors);
 
-  ~CommandReturnObject();
+  ~CommandReturnObject() = default;
 
   llvm::StringRef GetOutputData() {
     lldb::StreamSP stream_sp(m_out_stream.GetStreamAtIndex(eStreamStringIndex));

lldb/include/lldb/Interpreter/OptionGroupArchitecture.h

@@ -18,9 +18,9 @@ namespace lldb_private {
 
 class OptionGroupArchitecture : public OptionGroup {
 public:
-  OptionGroupArchitecture();
+  OptionGroupArchitecture() = default;
 
-  ~OptionGroupArchitecture() override;
+  ~OptionGroupArchitecture() override = default;
 
   llvm::ArrayRef<OptionDefinition> GetDefinitions() override;
 

lldb/include/lldb/Interpreter/OptionGroupBoolean.h

@@ -25,7 +25,7 @@ class OptionGroupBoolean : public OptionGroup {
                      const char *usage_text, bool default_value,
                      bool no_argument_toggle_default);
 
-  ~OptionGroupBoolean() override;
+  ~OptionGroupBoolean() override = default;
 
   llvm::ArrayRef<OptionDefinition> GetDefinitions() override {
     return llvm::ArrayRef<OptionDefinition>(&m_option_definition, 1);

lldb/include/lldb/Interpreter/OptionGroupFile.h

@@ -24,7 +24,7 @@ class OptionGroupFile : public OptionGroup {
                   lldb::CommandArgumentType argument_type,
                   const char *usage_text);
 
-  ~OptionGroupFile() override;
+  ~OptionGroupFile() override = default;
 
   llvm::ArrayRef<OptionDefinition> GetDefinitions() override {
     return llvm::ArrayRef<OptionDefinition>(&m_option_definition, 1);

lldb/include/lldb/Interpreter/OptionGroupFormat.h

@@ -32,13 +32,12 @@ class OptionGroupFormat : public OptionGroup {
       uint64_t default_count =
           UINT64_MAX); // Pass UINT64_MAX to disable the "--count" option
 
-  ~OptionGroupFormat() override;
+  ~OptionGroupFormat() override = default;
 
   llvm::ArrayRef<OptionDefinition> GetDefinitions() override;
 
   Status SetOptionValue(uint32_t option_idx, llvm::StringRef option_value,
                         ExecutionContext *execution_context) override;
-  Status SetOptionValue(uint32_t, const char *, ExecutionContext *) = delete;
 
   void OptionParsingStarting(ExecutionContext *execution_context) override;
 

lldb/include/lldb/Interpreter/OptionGroupOutputFile.h

@@ -20,13 +20,12 @@ class OptionGroupOutputFile : public OptionGroup {
 public:
   OptionGroupOutputFile();
 
-  ~OptionGroupOutputFile() override;
+  ~OptionGroupOutputFile() override = default;
 
   llvm::ArrayRef<OptionDefinition> GetDefinitions() override;
 
   Status SetOptionValue(uint32_t option_idx, llvm::StringRef option_value,
                         ExecutionContext *execution_context) override;
-  Status SetOptionValue(uint32_t, const char *, ExecutionContext *) = delete;
 
   void OptionParsingStarting(ExecutionContext *execution_context) override;
 

lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h

@@ -29,7 +29,7 @@ class OptionGroupPythonClassWithDict : public OptionGroup {
                                  int key_option = 'k', 
                                  int value_option = 'v');
 
-  ~OptionGroupPythonClassWithDict() override;
+  ~OptionGroupPythonClassWithDict() override = default;
 
   llvm::ArrayRef<OptionDefinition> GetDefinitions() override {
     return llvm::ArrayRef<OptionDefinition>(m_option_definition);

lldb/include/lldb/Interpreter/OptionGroupString.h

@@ -22,7 +22,7 @@ class OptionGroupString : public OptionGroup {
                     lldb::CommandArgumentType argument_type,
                     const char *usage_text, const char *default_value);
 
-  ~OptionGroupString() override;
+  ~OptionGroupString() override = default;
 
   llvm::ArrayRef<OptionDefinition> GetDefinitions() override {
     return llvm::ArrayRef<OptionDefinition>(&m_option_definition, 1);

lldb/include/lldb/Interpreter/OptionGroupUInt64.h

@@ -23,7 +23,7 @@ class OptionGroupUInt64 : public OptionGroup {
                     lldb::CommandArgumentType argument_type,
                     const char *usage_text, uint64_t default_value);
 
-  ~OptionGroupUInt64() override;
+  ~OptionGroupUInt64() override = default;
 
   llvm::ArrayRef<OptionDefinition> GetDefinitions() override {
     return llvm::ArrayRef<OptionDefinition>(&m_option_definition, 1);

lldb/include/lldb/Interpreter/OptionGroupUUID.h

@@ -18,9 +18,9 @@ namespace lldb_private {
 
 class OptionGroupUUID : public OptionGroup {
 public:
-  OptionGroupUUID();
+  OptionGroupUUID() = default;
 
-  ~OptionGroupUUID() override;
+  ~OptionGroupUUID() override = default;
 
   llvm::ArrayRef<OptionDefinition> GetDefinitions() override;
 

lldb/include/lldb/Interpreter/OptionGroupValueObjectDisplay.h

@@ -18,9 +18,9 @@ namespace lldb_private {
 
 class OptionGroupValueObjectDisplay : public OptionGroup {
 public:
-  OptionGroupValueObjectDisplay();
+  OptionGroupValueObjectDisplay() = default;
 
-  ~OptionGroupValueObjectDisplay() override;
+  ~OptionGroupValueObjectDisplay() override = default;
 
   llvm::ArrayRef<OptionDefinition> GetDefinitions() override;
 

lldb/include/lldb/Interpreter/OptionGroupVariable.h

@@ -20,7 +20,7 @@ class OptionGroupVariable : public OptionGroup {
 public:
   OptionGroupVariable(bool show_frame_options);
 
-  ~OptionGroupVariable() override;
+  ~OptionGroupVariable() override = default;
 
   llvm::ArrayRef<OptionDefinition> GetDefinitions() override;
 

lldb/include/lldb/Interpreter/OptionGroupWatchpoint.h

@@ -17,9 +17,9 @@ namespace lldb_private {
 
 class OptionGroupWatchpoint : public OptionGroup {
 public:
-  OptionGroupWatchpoint();
+  OptionGroupWatchpoint() = default;
 
-  ~OptionGroupWatchpoint() override;
+  ~OptionGroupWatchpoint() override = default;
 
   static bool IsWatchSizeSupported(uint32_t watch_size);
 

lldb/include/lldb/Interpreter/OptionValueArch.h

@@ -17,7 +17,7 @@ namespace lldb_private {
 
 class OptionValueArch : public OptionValue {
 public:
-  OptionValueArch() : OptionValue(), m_current_value(), m_default_value() {}
+  OptionValueArch() = default;
 
   OptionValueArch(const char *triple)
       : OptionValue(), m_current_value(triple), m_default_value() {
@@ -31,7 +31,7 @@ class OptionValueArch : public OptionValue {
       : OptionValue(), m_current_value(current_value),
         m_default_value(default_value) {}
 
-  ~OptionValueArch() override {}
+  ~OptionValueArch() override = default;
 
   // Virtual subclass pure virtual overrides
 

lldb/include/lldb/Interpreter/OptionValueArgs.h

@@ -19,7 +19,7 @@ class OptionValueArgs : public OptionValueArray {
       : OptionValueArray(
             OptionValue::ConvertTypeToMask(OptionValue::eTypeString)) {}
 
-  ~OptionValueArgs() override {}
+  ~OptionValueArgs() override = default;
 
   size_t GetArgs(Args &args);
 

lldb/include/lldb/Interpreter/OptionValueArray.h

@@ -20,7 +20,7 @@ class OptionValueArray : public OptionValue {
   OptionValueArray(uint32_t type_mask = UINT32_MAX, bool raw_value_dump = false)
       : m_type_mask(type_mask), m_values(), m_raw_value_dump(raw_value_dump) {}
 
-  ~OptionValueArray() override {}
+  ~OptionValueArray() override = default;
 
   // Virtual subclass pure virtual overrides
 

lldb/include/lldb/Interpreter/OptionValueBoolean.h

@@ -21,7 +21,7 @@ class OptionValueBoolean : public OptionValue {
       : OptionValue(), m_current_value(current_value),
         m_default_value(default_value) {}
 
-  ~OptionValueBoolean() override {}
+  ~OptionValueBoolean() override = default;
 
   // Virtual subclass pure virtual overrides
 

lldb/include/lldb/Interpreter/OptionValueChar.h

@@ -22,7 +22,7 @@ class OptionValueChar : public OptionValue {
       : OptionValue(), m_current_value(current_value),
         m_default_value(default_value) {}
 
-  ~OptionValueChar() override {}
+  ~OptionValueChar() override = default;
 
   // Virtual subclass pure virtual overrides
 

lldb/include/lldb/Interpreter/OptionValueDictionary.h

@@ -22,7 +22,7 @@ class OptionValueDictionary : public OptionValue {
       : OptionValue(), m_type_mask(type_mask), m_values(),
         m_raw_value_dump(raw_value_dump) {}
 
-  ~OptionValueDictionary() override {}
+  ~OptionValueDictionary() override = default;
 
   // Virtual subclass pure virtual overrides
 

lldb/include/lldb/Interpreter/OptionValueEnumeration.h

@@ -31,7 +31,7 @@ class OptionValueEnumeration : public OptionValue {
 
   OptionValueEnumeration(const OptionEnumValues &enumerators, enum_type value);
 
-  ~OptionValueEnumeration() override;
+  ~OptionValueEnumeration() override = default;
 
   // Virtual subclass pure virtual overrides
 

lldb/include/lldb/Interpreter/OptionValueFileColonLine.h

@@ -21,7 +21,7 @@ class OptionValueFileColonLine : public OptionValue {
   OptionValueFileColonLine();
   OptionValueFileColonLine(const llvm::StringRef input);
 
-  ~OptionValueFileColonLine() override {}
+  ~OptionValueFileColonLine() override = default;
 
   OptionValue::Type GetType() const override { return eTypeFileLineColumn; }
 

lldb/include/lldb/Interpreter/OptionValueFileSpec.h

@@ -25,7 +25,7 @@ class OptionValueFileSpec : public OptionValue {
   OptionValueFileSpec(const FileSpec &current_value,
                       const FileSpec &default_value, bool resolve = true);
 
-  ~OptionValueFileSpec() override {}
+  ~OptionValueFileSpec() override = default;
 
   // Virtual subclass pure virtual overrides
 

lldb/include/lldb/Interpreter/OptionValueFileSpecList.h

@@ -18,12 +18,12 @@ namespace lldb_private {
 
 class OptionValueFileSpecList : public OptionValue {
 public:
-  OptionValueFileSpecList() : OptionValue(), m_current_value() {}
+  OptionValueFileSpecList() = default;
 
   OptionValueFileSpecList(const FileSpecList &current_value)
       : OptionValue(), m_current_value(current_value) {}
 
-  ~OptionValueFileSpecList() override {}
+  ~OptionValueFileSpecList() override = default;
 
   // Virtual subclass pure virtual overrides
 

lldb/include/lldb/Interpreter/OptionValueFormat.h

@@ -22,7 +22,7 @@ class OptionValueFormat : public OptionValue {
       : OptionValue(), m_current_value(current_value),
         m_default_value(default_value) {}
 
-  ~OptionValueFormat() override {}
+  ~OptionValueFormat() override = default;
 
   // Virtual subclass pure virtual overrides
 

lldb/include/lldb/Interpreter/OptionValueFormatEntity.h

@@ -18,7 +18,7 @@ class OptionValueFormatEntity : public OptionValue {
 public:
   OptionValueFormatEntity(const char *default_format);
 
-  ~OptionValueFormatEntity() override {}
+  ~OptionValueFormatEntity() override = default;
 
   // Virtual subclass pure virtual overrides
 

lldb/include/lldb/Interpreter/OptionValueLanguage.h

@@ -25,7 +25,7 @@ class OptionValueLanguage : public OptionValue {
       : OptionValue(), m_current_value(current_value),
         m_default_value(default_value) {}
 
-  ~OptionValueLanguage() override {}
+  ~OptionValueLanguage() override = default;
 
   // Virtual subclass pure virtual overrides
 

lldb/include/lldb/Interpreter/OptionValuePathMappings.h

@@ -19,7 +19,7 @@ class OptionValuePathMappings : public OptionValue {
   OptionValuePathMappings(bool notify_changes)
       : OptionValue(), m_path_mappings(), m_notify_changes(notify_changes) {}
 
-  ~OptionValuePathMappings() override {}
+  ~OptionValuePathMappings() override = default;
 
   // Virtual subclass pure virtual overrides
 

lldb/include/lldb/Interpreter/OptionValueProperties.h

@@ -23,8 +23,7 @@ class OptionValueProperties
     : public OptionValue,
       public std::enable_shared_from_this<OptionValueProperties> {
 public:
-  OptionValueProperties()
-      : OptionValue(), m_name(), m_properties(), m_name_to_index() {}
+  OptionValueProperties() = default;
 
   OptionValueProperties(ConstString name);
 

lldb/include/lldb/Interpreter/OptionValueSInt64.h

@@ -16,9 +16,7 @@ namespace lldb_private {
 
 class OptionValueSInt64 : public OptionValue {
 public:
-  OptionValueSInt64()
-      : OptionValue(), m_current_value(0), m_default_value(0),
-        m_min_value(INT64_MIN), m_max_value(INT64_MAX) {}
+  OptionValueSInt64() = default;
 
   OptionValueSInt64(int64_t value)
       : OptionValue(), m_current_value(value), m_default_value(value),
@@ -29,12 +27,9 @@ class OptionValueSInt64 : public OptionValue {
         m_default_value(default_value), m_min_value(INT64_MIN),
         m_max_value(INT64_MAX) {}
 
-  OptionValueSInt64(const OptionValueSInt64 &rhs)
-      : OptionValue(rhs), m_current_value(rhs.m_current_value),
-        m_default_value(rhs.m_default_value), m_min_value(rhs.m_min_value),
-        m_max_value(rhs.m_max_value) {}
+  OptionValueSInt64(const OptionValueSInt64 &rhs) = default;
 
-  ~OptionValueSInt64() override {}
+  ~OptionValueSInt64() override = default;
 
   // Virtual subclass pure virtual overrides
 
@@ -90,10 +85,10 @@ class OptionValueSInt64 : public OptionValue {
   int64_t GetMaximumValue() const { return m_max_value; }
 
 protected:
-  int64_t m_current_value;
-  int64_t m_default_value;
-  int64_t m_min_value;
-  int64_t m_max_value;
+  int64_t m_current_value = 0;
+  int64_t m_default_value = 0;
+  int64_t m_min_value = INT64_MIN;
+  int64_t m_max_value = INT64_MAX;
 };
 
 } // namespace lldb_private

lldb/include/lldb/Interpreter/OptionValueString.h

@@ -23,9 +23,7 @@ class OptionValueString : public OptionValue {
 
   enum Options { eOptionEncodeCharacterEscapeSequences = (1u << 0) };
 
-  OptionValueString()
-      : OptionValue(), m_current_value(), m_default_value(), m_options(),
-        m_validator(), m_validator_baton() {}
+  OptionValueString() = default;
 
   OptionValueString(ValidatorCallback validator, void *baton = nullptr)
       : OptionValue(), m_current_value(), m_default_value(), m_options(),
@@ -125,8 +123,8 @@ class OptionValueString : public OptionValue {
   std::string m_current_value;
   std::string m_default_value;
   Flags m_options;
-  ValidatorCallback m_validator;
-  void *m_validator_baton;
+  ValidatorCallback m_validator = nullptr;
+  void *m_validator_baton = nullptr;
 };
 
 } // namespace lldb_private