Skip to content

Commit 559d142

Browse files
dougpuobnico
dougpuob
authored and
nico
committed
[clang-tidy] Fix command line is too long issue which breaks test on Windows
This patch tries to fix command line too long problem on Windows for https://reviews.llvm.org/D86671. The command line is too long with check_clang_tidy.py program on Windows, because the configuration is long for regression test. Fix this issue by passing the settings in file instead. Differential Revision: https://reviews.llvm.org/D107325
1 parent 2e75986 commit 559d142

File tree

5 files changed

+392
-197
lines changed

5 files changed

+392
-197
lines changed

‎clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -491,6 +491,8 @@ void IdentifierNamingCheck::HungarianNotation::loadFileConfig(
491491
std::string IdentifierNamingCheck::HungarianNotation::getPrefix(
492492
const Decl *D,
493493
const IdentifierNamingCheck::HungarianNotationOption &HNOption) const {
494+
if (!D)
495+
return {};
494496
const auto *ND = dyn_cast<NamedDecl>(D);
495497
if (!ND)
496498
return {};

‎clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-identifier-naming/hungarian-notation1/.clang-tidy

Lines changed: 114 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,114 @@
1+
Checks: readability-identifier-naming
2+
CheckOptions:
3+
- key: readability-identifier-naming.AbstractClassCase
4+
value: CamelCase
5+
- key: readability-identifier-naming.ClassCase
6+
value: CamelCase
7+
- key: readability-identifier-naming.ClassConstantCase
8+
value: CamelCase
9+
- key: readability-identifier-naming.ClassMemberCase
10+
value: CamelCase
11+
- key: readability-identifier-naming.ConstantCase
12+
value: CamelCase
13+
- key: readability-identifier-naming.ConstantMemberCase
14+
value: CamelCase
15+
- key: readability-identifier-naming.ConstantParameterCase
16+
value: CamelCase
17+
- key: readability-identifier-naming.ConstantPointerParameterCase
18+
value: CamelCase
19+
- key: readability-identifier-naming.ConstexprVariableCase
20+
value: CamelCase
21+
- key: readability-identifier-naming.EnumConstantCase
22+
value: CamelCase
23+
- key: readability-identifier-naming.GlobalConstantCase
24+
value: CamelCase
25+
- key: readability-identifier-naming.GlobalConstantPointerCase
26+
value: CamelCase
27+
- key: readability-identifier-naming.GlobalPointerCase
28+
value: CamelCase
29+
- key: readability-identifier-naming.GlobalVariableCase
30+
value: CamelCase
31+
- key: readability-identifier-naming.LocalConstantCase
32+
value: CamelCase
33+
- key: readability-identifier-naming.LocalConstantPointerCase
34+
value: CamelCase
35+
- key: readability-identifier-naming.LocalPointerCase
36+
value: CamelCase
37+
- key: readability-identifier-naming.LocalVariableCase
38+
value: CamelCase
39+
- key: readability-identifier-naming.MemberCase
40+
value: CamelCase
41+
- key: readability-identifier-naming.ParameterCase
42+
value: CamelCase
43+
- key: readability-identifier-naming.PointerParameterCase
44+
value: CamelCase
45+
- key: readability-identifier-naming.PrivateMemberCase
46+
value: CamelCase
47+
- key: readability-identifier-naming.ProtectedMemberCase
48+
value: CamelCase
49+
- key: readability-identifier-naming.PublicMemberCase
50+
value: CamelCase
51+
- key: readability-identifier-naming.ScopedEnumConstantCase
52+
value: CamelCase
53+
- key: readability-identifier-naming.StaticConstantCase
54+
value: CamelCase
55+
- key: readability-identifier-naming.StaticVariableCase
56+
value: CamelCase
57+
- key: readability-identifier-naming.VariableCase
58+
value: CamelCase
59+
- key: readability-identifier-naming.AbstractClassHungarianPrefix
60+
value: On
61+
- key: readability-identifier-naming.ClassHungarianPrefix
62+
value: On
63+
- key: readability-identifier-naming.ClassConstantHungarianPrefix
64+
value: On
65+
- key: readability-identifier-naming.ClassMemberHungarianPrefix
66+
value: On
67+
- key: readability-identifier-naming.ConstantHungarianPrefix
68+
value: On
69+
- key: readability-identifier-naming.ConstantMemberHungarianPrefix
70+
value: On
71+
- key: readability-identifier-naming.ConstantParameterHungarianPrefix
72+
value: On
73+
- key: readability-identifier-naming.ConstantPointerParameterHungarianPrefix
74+
value: On
75+
- key: readability-identifier-naming.ConstexprVariableHungarianPrefix
76+
value: On
77+
- key: readability-identifier-naming.EnumConstantHungarianPrefix
78+
value: On
79+
- key: readability-identifier-naming.GlobalConstantHungarianPrefix
80+
value: On
81+
- key: readability-identifier-naming.GlobalConstantPointerHungarianPrefix
82+
value: On
83+
- key: readability-identifier-naming.GlobalPointerHungarianPrefix
84+
value: On
85+
- key: readability-identifier-naming.GlobalVariableHungarianPrefix
86+
value: On
87+
- key: readability-identifier-naming.LocalConstantHungarianPrefix
88+
value: On
89+
- key: readability-identifier-naming.LocalConstantPointerHungarianPrefix
90+
value: On
91+
- key: readability-identifier-naming.LocalPointerHungarianPrefix
92+
value: On
93+
- key: readability-identifier-naming.LocalVariableHungarianPrefix
94+
value: On
95+
- key: readability-identifier-naming.MemberHungarianPrefix
96+
value: On
97+
- key: readability-identifier-naming.ParameterHungarianPrefix
98+
value: On
99+
- key: readability-identifier-naming.PointerParameterHungarianPrefix
100+
value: On
101+
- key: readability-identifier-naming.PrivateMemberHungarianPrefix
102+
value: On
103+
- key: readability-identifier-naming.ProtectedMemberHungarianPrefix
104+
value: On
105+
- key: readability-identifier-naming.PublicMemberHungarianPrefix
106+
value: On
107+
- key: readability-identifier-naming.ScopedEnumConstantHungarianPrefix
108+
value: On
109+
- key: readability-identifier-naming.StaticConstantHungarianPrefix
110+
value: On
111+
- key: readability-identifier-naming.StaticVariableHungarianPrefix
112+
value: On
113+
- key: readability-identifier-naming.VariableHungarianPrefix
114+
value: On

‎clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-identifier-naming/hungarian-notation2/.clang-tidy

Lines changed: 272 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,272 @@
1+
Checks: readability-identifier-naming
2+
CheckOptions:
3+
- key: readability-identifier-naming.AbstractClassCase
4+
value: CamelCase
5+
- key: readability-identifier-naming.ClassCase
6+
value: CamelCase
7+
- key: readability-identifier-naming.ClassConstantCase
8+
value: CamelCase
9+
- key: readability-identifier-naming.ClassMemberCase
10+
value: CamelCase
11+
- key: readability-identifier-naming.ConstantCase
12+
value: CamelCase
13+
- key: readability-identifier-naming.ConstantMemberCase
14+
value: CamelCase
15+
- key: readability-identifier-naming.ConstantParameterCase
16+
value: CamelCase
17+
- key: readability-identifier-naming.ConstantPointerParameterCase
18+
value: CamelCase
19+
- key: readability-identifier-naming.ConstexprVariableCase
20+
value: CamelCase
21+
- key: readability-identifier-naming.EnumConstantCase
22+
value: CamelCase
23+
- key: readability-identifier-naming.GlobalConstantCase
24+
value: CamelCase
25+
- key: readability-identifier-naming.GlobalConstantPointerCase
26+
value: CamelCase
27+
- key: readability-identifier-naming.GlobalPointerCase
28+
value: CamelCase
29+
- key: readability-identifier-naming.GlobalVariableCase
30+
value: CamelCase
31+
- key: readability-identifier-naming.LocalConstantCase
32+
value: CamelCase
33+
- key: readability-identifier-naming.LocalConstantPointerCase
34+
value: CamelCase
35+
- key: readability-identifier-naming.LocalPointerCase
36+
value: CamelCase
37+
- key: readability-identifier-naming.LocalVariableCase
38+
value: CamelCase
39+
- key: readability-identifier-naming.MemberCase
40+
value: CamelCase
41+
- key: readability-identifier-naming.ParameterCase
42+
value: CamelCase
43+
- key: readability-identifier-naming.PointerParameterCase
44+
value: CamelCase
45+
- key: readability-identifier-naming.PrivateMemberCase
46+
value: CamelCase
47+
- key: readability-identifier-naming.ProtectedMemberCase
48+
value: CamelCase
49+
- key: readability-identifier-naming.PublicMemberCase
50+
value: CamelCase
51+
- key: readability-identifier-naming.ScopedEnumConstantCase
52+
value: CamelCase
53+
- key: readability-identifier-naming.StaticConstantCase
54+
value: CamelCase
55+
- key: readability-identifier-naming.StaticVariableCase
56+
value: CamelCase
57+
- key: readability-identifier-naming.VariableCase
58+
value: CamelCase
59+
- key: readability-identifier-naming.AbstractClassHungarianPrefix
60+
value: On
61+
- key: readability-identifier-naming.ClassHungarianPrefix
62+
value: On
63+
- key: readability-identifier-naming.ClassConstantHungarianPrefix
64+
value: On
65+
- key: readability-identifier-naming.ClassMemberHungarianPrefix
66+
value: On
67+
- key: readability-identifier-naming.ConstantHungarianPrefix
68+
value: On
69+
- key: readability-identifier-naming.ConstantMemberHungarianPrefix
70+
value: On
71+
- key: readability-identifier-naming.ConstantParameterHungarianPrefix
72+
value: On
73+
- key: readability-identifier-naming.ConstantPointerParameterHungarianPrefix
74+
value: On
75+
- key: readability-identifier-naming.ConstexprVariableHungarianPrefix
76+
value: On
77+
- key: readability-identifier-naming.EnumConstantHungarianPrefix
78+
value: On
79+
- key: readability-identifier-naming.GlobalConstantHungarianPrefix
80+
value: On
81+
- key: readability-identifier-naming.GlobalConstantPointerHungarianPrefix
82+
value: On
83+
- key: readability-identifier-naming.GlobalPointerHungarianPrefix
84+
value: On
85+
- key: readability-identifier-naming.GlobalVariableHungarianPrefix
86+
value: On
87+
- key: readability-identifier-naming.LocalConstantHungarianPrefix
88+
value: On
89+
- key: readability-identifier-naming.LocalConstantPointerHungarianPrefix
90+
value: On
91+
- key: readability-identifier-naming.LocalPointerHungarianPrefix
92+
value: On
93+
- key: readability-identifier-naming.LocalVariableHungarianPrefix
94+
value: On
95+
- key: readability-identifier-naming.MemberHungarianPrefix
96+
value: On
97+
- key: readability-identifier-naming.ParameterHungarianPrefix
98+
value: On
99+
- key: readability-identifier-naming.PointerParameterHungarianPrefix
100+
value: On
101+
- key: readability-identifier-naming.PrivateMemberHungarianPrefix
102+
value: On
103+
- key: readability-identifier-naming.ProtectedMemberHungarianPrefix
104+
value: On
105+
- key: readability-identifier-naming.PublicMemberHungarianPrefix
106+
value: On
107+
- key: readability-identifier-naming.ScopedEnumConstantHungarianPrefix
108+
value: On
109+
- key: readability-identifier-naming.StaticConstantHungarianPrefix
110+
value: On
111+
- key: readability-identifier-naming.StaticVariableHungarianPrefix
112+
value: On
113+
- key: readability-identifier-naming.VariableHungarianPrefix
114+
value: On
115+
- key: readability-identifier-naming.HungarianNotation.Options.TreatStructAsClass
116+
value: false
117+
- key: readability-identifier-naming.HungarianNotation.DerivedType.Array
118+
value: ary
119+
- key: readability-identifier-naming.HungarianNotation.DerivedType.Pointer
120+
value: p
121+
- key: readability-identifier-naming.HungarianNotation.DerivedType.FunctionPointer
122+
value: fn
123+
- key: readability-identifier-naming.HungarianNotation.CString.CharPrinter
124+
value: sz
125+
- key: readability-identifier-naming.HungarianNotation.CString.CharArray
126+
value: sz
127+
- key: readability-identifier-naming.HungarianNotation.CString.WideCharPrinter
128+
value: wsz
129+
- key: readability-identifier-naming.HungarianNotation.CString.WideCharArray
130+
value: wsz
131+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.int8_t
132+
value: i8
133+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.int16_t
134+
value: i16
135+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.int32_t
136+
value: i32
137+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.int64_t
138+
value: i64
139+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.uint8_t
140+
value: u8
141+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.uint16_t
142+
value: u16
143+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.uint32_t
144+
value: u32
145+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.uint64_t
146+
value: u64
147+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.char8_t
148+
value: c8
149+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.char16_t
150+
value: c16
151+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.char32_t
152+
value: c32
153+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.float
154+
value: f
155+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.double
156+
value: d
157+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.char
158+
value: c
159+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.bool
160+
value: b
161+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType._Bool
162+
value: b
163+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.int
164+
value: i
165+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.size_t
166+
value: n
167+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.wchar_t
168+
value: wc
169+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.short-int
170+
value: si
171+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.short
172+
value: s
173+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-int
174+
value: si
175+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-short
176+
value: ss
177+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-short-int
178+
value: ssi
179+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-long-long-int
180+
value: slli
181+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-long-long
182+
value: sll
183+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-long-int
184+
value: sli
185+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed-long
186+
value: sl
187+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.signed
188+
value: s
189+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-long-long-int
190+
value: ulli
191+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-long-long
192+
value: ull
193+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-long-int
194+
value: uli
195+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-long
196+
value: ul
197+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-short-int
198+
value: usi
199+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-short
200+
value: us
201+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned-int
202+
value: ui
203+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.unsigned
204+
value: u
205+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.long-long-int
206+
value: lli
207+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.long-double
208+
value: ld
209+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.long-long
210+
value: ll
211+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.long-int
212+
value: li
213+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.long
214+
value: l
215+
- key: readability-identifier-naming.HungarianNotation.PrimitiveType.ptrdiff_t
216+
value: p
217+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.BOOL
218+
value: b
219+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.BOOLEAN
220+
value: b
221+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.BYTE
222+
value: by
223+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.CHAR
224+
value: c
225+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.UCHAR
226+
value: uc
227+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.SHORT
228+
value: s
229+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.USHORT
230+
value: us
231+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.WORD
232+
value: w
233+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.DWORD
234+
value: dw
235+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.DWORD32
236+
value: dw32
237+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.DWORD64
238+
value: dw64
239+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.LONG
240+
value: l
241+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.ULONG
242+
value: ul
243+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.ULONG32
244+
value: ul32
245+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.ULONG64
246+
value: ul64
247+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.ULONGLONG
248+
value: ull
249+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.HANDLE
250+
value: h
251+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT
252+
value: i
253+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT8
254+
value: i8
255+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT16
256+
value: i16
257+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT32
258+
value: i32
259+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.INT64
260+
value: i64
261+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT
262+
value: ui
263+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT8
264+
value: u8
265+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT16
266+
value: u16
267+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT32
268+
value: u32
269+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.UINT64
270+
value: u64
271+
- key: readability-identifier-naming.HungarianNotation.UserDefinedType.PVOID
272+
value: p

0 commit comments

Comments
 (0)