[clangd] Make PopulateSwitch a fix.

sam-mccall · sam-mccall · commit 57ac47d78885 · 2020-10-02T13:24:24.000+02:00
It fixes the -Wswitch warning, though we mark it as a fix even if that is off. This makes it the "recommended" action on an incomplete switch, which seems OK. Differential Revision: https://reviews.llvm.org/D88726
diff --git a/clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp b/clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp
@@ -53,7 +53,7 @@ class PopulateSwitch : public Tweak {
   Expected<Effect> apply(const Selection &Sel) override;
   std::string title() const override { return "Populate switch"; }
   llvm::StringLiteral kind() const override {
-    return CodeAction::REFACTOR_KIND;
+    return CodeAction::QUICKFIX_KIND;
   }
 
 private:

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ class PopulateSwitch : public Tweak {`
`53`	`53`	`Expected<Effect> apply(const Selection &Sel) override;`
`54`	`54`	`std::string title() const override { return "Populate switch"; }`
`55`	`55`	`llvm::StringLiteral kind() const override {`
`56`		`- return CodeAction::REFACTOR_KIND;`
	`56`	`+ return CodeAction::QUICKFIX_KIND;`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`private:`