Skip to content

Commit 6527b2a

Browse files
committed
[AMDGPU][NFC] Fix typos
Fix some typos in the amdgpu backend. Differential Revision: https://reviews.llvm.org/D119235
1 parent b467043 commit 6527b2a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+108
-109
lines changed

llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -877,7 +877,7 @@ static Value* getMulHu(IRBuilder<> &Builder, Value *LHS, Value *RHS) {
877877
return getMul64(Builder, LHS, RHS).second;
878878
}
879879

880-
/// Figure out how many bits are really needed for this ddivision. \p AtLeast is
880+
/// Figure out how many bits are really needed for this division. \p AtLeast is
881881
/// an optimization hint to bypass the second ComputeNumSignBits call if we the
882882
/// first one is insufficient. Returns -1 on failure.
883883
int AMDGPUCodeGenPrepare::getDivNumBits(BinaryOperator &I,

llvm/lib/Target/AMDGPU/AMDGPUGISel.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def gi_smrd_buffer_imm32 :
123123

124124
// Separate load nodes are defined to glue m0 initialization in
125125
// SelectionDAG. The GISel selector can just insert m0 initialization
126-
// directly before before selecting a glue-less load, so hide this
126+
// directly before selecting a glue-less load, so hide this
127127
// distinction.
128128

129129
def : GINodeEquiv<G_LOAD, AMDGPUld_glue> {

llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2840,7 +2840,7 @@ bool AMDGPUDAGToDAGISel::isVGPRImm(const SDNode * N) const {
28402840
}
28412841
}
28422842
}
2843-
// If "AllUsesAcceptSReg == false" so far we haven't suceeded
2843+
// If "AllUsesAcceptSReg == false" so far we haven't succeeded
28442844
// commuting current user. This means have at least one use
28452845
// that strictly require VGPR. Thus, we will not attempt to commute
28462846
// other user instructions.

llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1627,7 +1627,7 @@ bool AMDGPUInstructionSelector::selectImageIntrinsic(
16271627
}
16281628

16291629
// The legalizer preprocessed the intrinsic arguments. If we aren't using
1630-
// NSA, these should have beeen packed into a single value in the first
1630+
// NSA, these should have been packed into a single value in the first
16311631
// address register
16321632
const bool UseNSA = NumVAddrRegs != 1 && NumVAddrDwords == NumVAddrRegs;
16331633
if (UseNSA && !STI.hasFeature(AMDGPU::FeatureNSAEncoding)) {

llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1510,7 +1510,7 @@ AMDGPULegalizerInfo::AMDGPULegalizerInfo(const GCNSubtarget &ST_,
15101510
.clampMaxNumElements(1, S16, 2) // TODO: Make 4?
15111511
.clampMaxNumElements(0, S16, 64);
15121512

1513-
// TODO: Don't fully scalarize v2s16 pieces? Or combine out thosse
1513+
// TODO: Don't fully scalarize v2s16 pieces? Or combine out those
15141514
// pre-legalize.
15151515
if (ST.hasVOP3PInsts()) {
15161516
getActionDefinitionsBuilder(G_SHUFFLE_VECTOR)
@@ -4377,7 +4377,7 @@ static void convertImageAddrToPacked(MachineIRBuilder &B, MachineInstr &MI,
43774377
///
43784378
/// We don't want to directly select image instructions just yet, but also want
43794379
/// to exposes all register repacking to the legalizer/combiners. We also don't
4380-
/// want a selected instrution entering RegBankSelect. In order to avoid
4380+
/// want a selected instruction entering RegBankSelect. In order to avoid
43814381
/// defining a multitude of intermediate image instructions, directly hack on
43824382
/// the intrinsic's arguments. In cases like a16 addresses, this requires
43834383
/// padding now unnecessary arguments with $noreg.

llvm/lib/Target/AMDGPU/AMDGPULowerKernelArguments.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ bool AMDGPULowerKernelArguments::runOnFunction(Function &F) {
7373
const uint64_t BaseOffset = ST.getExplicitKernelArgOffset(F);
7474

7575
Align MaxAlign;
76-
// FIXME: Alignment is broken broken with explicit arg offset.;
76+
// FIXME: Alignment is broken with explicit arg offset.;
7777
const uint64_t TotalKernArgSize = ST.getKernArgSegmentSize(F, MaxAlign);
7878
if (TotalKernArgSize == 0)
7979
return false;

llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
// known address. AMDGPUMachineFunction allocates the LDS global.
1515
//
1616
// Local variables with constant annotation or non-undef initializer are passed
17-
// through unchanged for simplication or error diagnostics in later passes.
17+
// through unchanged for simplification or error diagnostics in later passes.
1818
//
1919
// To reduce the memory overhead variables that are only used by kernels are
2020
// excluded from this transform. The analysis to determine whether a variable

llvm/lib/Target/AMDGPU/AMDGPUMachineCFGStructurizer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1295,7 +1295,7 @@ static void fixRegionTerminator(RegionMRT *Region) {
12951295
}
12961296
}
12971297

1298-
// If a region region is just a sequence of regions (and the exit
1298+
// If a region is just a sequence of regions (and the exit
12991299
// block in the case of the top level region), we can simply skip
13001300
// linearizing it, because it is already linear
13011301
bool regionIsSequence(RegionMRT *Region) {

llvm/lib/Target/AMDGPU/AMDGPUOpenCLEnqueuedBlockLowering.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ ModulePass* llvm::createAMDGPUOpenCLEnqueuedBlockLoweringPass() {
7171
return new AMDGPUOpenCLEnqueuedBlockLowering();
7272
}
7373

74-
/// Collect direct or indrect callers of \p F and save them
74+
/// Collect direct or indirect callers of \p F and save them
7575
/// to \p Callers.
7676
static void collectCallers(Function *F, DenseSet<Function *> &Callers) {
7777
for (auto U : F->users()) {

llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -917,7 +917,7 @@ bool AMDGPUPromoteAllocaImpl::handleAlloca(AllocaInst &I, bool SufficientLDS) {
917917
// usage order.
918918
//
919919
// FIXME: It is also possible that if we're allowed to use all of the memory
920-
// could could end up using more than the maximum due to alignment padding.
920+
// could end up using more than the maximum due to alignment padding.
921921

922922
uint32_t NewSize = alignTo(CurrentLocalMemUsage, Alignment);
923923
uint32_t AllocSize = WorkGroupSize * DL.getTypeAllocSize(AllocaTy);

llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1789,7 +1789,7 @@ bool AMDGPURegisterBankInfo::buildVCopy(MachineIRBuilder &B, Register DstReg,
17891789
}
17901790

17911791
/// Utility function for pushing dynamic vector indexes with a constant offset
1792-
/// into waterwall loops.
1792+
/// into waterfall loops.
17931793
static void reinsertVectorIndexAdd(MachineIRBuilder &B,
17941794
MachineInstr &IdxUseInstr,
17951795
unsigned OpIdx,

llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
//===----------------------------------------------------------------------===//
88
//
99
/// \file
10-
/// The AMDGPU TargetMachine interface definition for hw codgen targets.
10+
/// The AMDGPU TargetMachine interface definition for hw codegen targets.
1111
//
1212
//===----------------------------------------------------------------------===//
1313

llvm/lib/Target/AMDGPU/AMDILCFGStructurizer.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1487,8 +1487,7 @@ int AMDGPUCFGStructurizer::cloneOnSideEntryTo(MachineBasicBlock *PreMBB,
14871487
MachineBasicBlock *
14881488
AMDGPUCFGStructurizer::cloneBlockForPredecessor(MachineBasicBlock *MBB,
14891489
MachineBasicBlock *PredMBB) {
1490-
assert(PredMBB->isSuccessor(MBB) &&
1491-
"succBlk is not a prececessor of curBlk");
1490+
assert(PredMBB->isSuccessor(MBB) && "succBlk is not a predecessor of curBlk");
14921491

14931492
MachineBasicBlock *CloneMBB = clone(MBB); //clone instructions
14941493
replaceInstrUseOfBlockWith(PredMBB, MBB, CloneMBB);

llvm/lib/Target/AMDGPU/AMDKernelCodeT.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ enum amd_code_property_mask_t {
142142
/// is provided to the finalizer when it is invoked and is recorded
143143
/// here. The hardware will interleave the memory requests of each
144144
/// lane of a wavefront by this element size to ensure each
145-
/// work-item gets a distinct memory memory location. Therefore, the
145+
/// work-item gets a distinct memory location. Therefore, the
146146
/// finalizer ensures that all load and store operations done to
147147
/// private memory do not exceed this size. For example, if the
148148
/// element size is 4 (32-bits or dword) and a 64-bit value must be

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1930,7 +1930,7 @@ bool AMDGPUOperand::isLiteralImm(MVT type) const {
19301930

19311931
// We allow fp literals with f16x2 operands assuming that the specified
19321932
// literal goes into the lower half and the upper half is zero. We also
1933-
// require that the literal may be losslesly converted to f16.
1933+
// require that the literal may be losslessly converted to f16.
19341934
MVT ExpectedType = (type == MVT::v2f16)? MVT::f16 :
19351935
(type == MVT::v2i16)? MVT::i16 :
19361936
(type == MVT::v2f32)? MVT::f32 : type;
@@ -2960,7 +2960,7 @@ AMDGPUAsmParser::isModifier() {
29602960
// v_exp_f32_e32 v5, -1 // VOP1: src0 = 0xFFFFFFFF
29612961
// v_exp_f32_e64 v5, -1 // VOP3: src0 = 0x80000001
29622962
// Negative fp literals with preceding "-" are
2963-
// handled likewise for unifomtity
2963+
// handled likewise for uniformity
29642964
//
29652965
bool
29662966
AMDGPUAsmParser::parseSP3NegModifier() {
@@ -6342,7 +6342,7 @@ AMDGPUAsmParser::validateSendMsg(const OperandInfoTy &Msg,
63426342
using namespace llvm::AMDGPU::SendMsg;
63436343

63446344
// Validation strictness depends on whether message is specified
6345-
// in a symbolc or in a numeric form. In the latter case
6345+
// in a symbolic or in a numeric form. In the latter case
63466346
// only encoding possibility is checked.
63476347
bool Strict = Msg.IsSymbolic;
63486348

@@ -8384,7 +8384,7 @@ extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeAMDGPUAsmParser() {
83848384
#define GET_MNEMONIC_CHECKER
83858385
#include "AMDGPUGenAsmMatcher.inc"
83868386

8387-
// This fuction should be defined after auto-generated include so that we have
8387+
// This function should be defined after auto-generated include so that we have
83888388
// MatchClassKind enum defined
83898389
unsigned AMDGPUAsmParser::validateTargetOperandClass(MCParsedAsmOperand &Op,
83908390
unsigned Kind) {

llvm/lib/Target/AMDGPU/BUFInstructions.td

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ class MTBUF_Real <MTBUF_Pseudo ps> :
136136
bits<3> nfmt = format{6-4};
137137

138138
// GFX90A+ only: instruction uses AccVGPR for data
139-
// Bit superceedes tfe.
139+
// Bit supersedes tfe.
140140
bits<1> acc = !if(ps.has_vdata, vdata{9}, 0);
141141
}
142142

@@ -370,7 +370,7 @@ class MUBUF_Real <MUBUF_Pseudo ps> :
370370
bits<8> soffset;
371371

372372
// GFX90A+ only: instruction uses AccVGPR for data
373-
// Bit superceedes tfe.
373+
// Bit supersedes tfe.
374374
bits<1> acc = !if(ps.has_vdata, vdata{9}, 0);
375375
}
376376

llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
using namespace llvm;
2121

2222
//===----------------------------------------------------------------------===//
23-
// Hazard Recoginizer Implementation
23+
// Hazard Recognizer Implementation
2424
//===----------------------------------------------------------------------===//
2525

2626
static bool shouldRunLdsBranchVmemWARHazardFixup(const MachineFunction &MF,
@@ -534,7 +534,7 @@ int GCNHazardRecognizer::checkSoftClauseHazards(MachineInstr *MEM) {
534534
// In order to handle these situations correctly we need to make sure that
535535
// when a clause has more than one instruction, no instruction in the clause
536536
// writes to a register that is read by another instruction in the clause
537-
// (including itself). If we encounter this situaion, we need to break the
537+
// (including itself). If we encounter this situation, we need to break the
538538
// clause by inserting a non SMEM instruction.
539539

540540
for (MachineInstr *MI : EmittedInstrs) {

llvm/lib/Target/AMDGPU/GCNNSAReassign.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//===-- GCNNSAReassign.cpp - Reassign registers in NSA unstructions -------===//
1+
//===-- GCNNSAReassign.cpp - Reassign registers in NSA instructions -------===//
22
//
33
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
44
// See https://llvm.org/LICENSE.txt for license information.
@@ -8,7 +8,7 @@
88
//
99
/// \file
1010
/// \brief Try to reassign registers on GFX10+ from non-sequential to sequential
11-
/// in NSA image instructions. Later SIShrinkInstructions pass will relace NSA
11+
/// in NSA image instructions. Later SIShrinkInstructions pass will replace NSA
1212
/// with sequential versions where possible.
1313
///
1414
//===----------------------------------------------------------------------===//

llvm/lib/Target/AMDGPU/GCNRegPressure.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
/// This file defines the GCNRegPressure class, which tracks registry pressure
1111
/// by bookkeeping number of SGPR/VGPRs used, weights for large SGPR/VGPRs. It
1212
/// also implements a compare function, which compares different register
13-
/// pressures, and declares one with max occupance as winner.
13+
/// pressures, and declares one with max occupancy as winner.
1414
///
1515
//===----------------------------------------------------------------------===//
1616

llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -695,7 +695,7 @@ AMDGPUTargetELFStreamer::EmitDirectiveHSACodeObjectISAV2(uint32_t Major,
695695
OS.emitBytes(VendorName);
696696
OS.emitInt8(0); // NULL terminate VendorName
697697
OS.emitBytes(ArchName);
698-
OS.emitInt8(0); // NULL terminte ArchName
698+
OS.emitInt8(0); // NULL terminate ArchName
699699
});
700700
}
701701

llvm/lib/Target/AMDGPU/R600ClauseMergePass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
//===----------------------------------------------------------------------===//
88
//
99
/// \file
10-
/// R600EmitClauseMarker pass emits CFAlu instruction in a conservative maneer.
10+
/// R600EmitClauseMarker pass emits CFAlu instruction in a conservative manner.
1111
/// This pass is merging consecutive CFAlus where applicable.
1212
/// It needs to be called after IfCvt for best results.
1313
//===----------------------------------------------------------------------===//

llvm/lib/Target/AMDGPU/R600EmitClauseMarkers.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -327,9 +327,9 @@ char R600EmitClauseMarkers::ID = 0;
327327
} // end anonymous namespace
328328

329329
INITIALIZE_PASS_BEGIN(R600EmitClauseMarkers, "emitclausemarkers",
330-
"R600 Emit Clause Markters", false, false)
330+
"R600 Emit Clause Markers", false, false)
331331
INITIALIZE_PASS_END(R600EmitClauseMarkers, "emitclausemarkers",
332-
"R600 Emit Clause Markters", false, false)
332+
"R600 Emit Clause Markers", false, false)
333333

334334
FunctionPass *llvm::createR600EmitClauseMarkers() {
335335
return new R600EmitClauseMarkers();

llvm/lib/Target/AMDGPU/R600ISelLowering.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -995,7 +995,7 @@ SDValue R600TargetLowering::LowerSELECT_CC(SDValue Op, SelectionDAG &DAG) const
995995
/// LLVM generates byte-addressed pointers. For indirect addressing, we need to
996996
/// convert these pointers to a register index. Each register holds
997997
/// 16 bytes, (4 x 32bit sub-register), but we need to take into account the
998-
/// \p StackWidth, which tells us how many of the 4 sub-registrers will be used
998+
/// \p StackWidth, which tells us how many of the 4 sub-registers will be used
999999
/// for indirect addressing.
10001000
SDValue R600TargetLowering::stackPtrToRegIndex(SDValue Ptr,
10011001
unsigned StackWidth,
@@ -1100,7 +1100,7 @@ SDValue R600TargetLowering::lowerPrivateTruncStore(StoreSDNode *Store,
11001100
SDValue ShiftAmt = DAG.getNode(ISD::SHL, DL, MVT::i32, ByteIdx,
11011101
DAG.getConstant(3, DL, MVT::i32));
11021102

1103-
// TODO: Contrary to the name of the functiom,
1103+
// TODO: Contrary to the name of the function,
11041104
// it also handles sub i32 non-truncating stores (like i1)
11051105
SDValue SExtValue = DAG.getNode(ISD::SIGN_EXTEND, DL, MVT::i32,
11061106
Store->getValue());
@@ -1610,7 +1610,7 @@ static SDValue CompactSwizzlableVector(
16101610
if (NewBldVec[i].isUndef())
16111611
// We mask write here to teach later passes that the ith element of this
16121612
// vector is undef. Thus we can use it to reduce 128 bits reg usage,
1613-
// break false dependencies and additionnaly make assembly easier to read.
1613+
// break false dependencies and additionally make assembly easier to read.
16141614
RemapSwizzle[i] = 7; // SEL_MASK_WRITE
16151615
if (ConstantFPSDNode *C = dyn_cast<ConstantFPSDNode>(NewBldVec[i])) {
16161616
if (C->isZero()) {

llvm/lib/Target/AMDGPU/R600Packetizer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ class R600PacketizerList : public VLIWPacketizerList {
207207
return !ARDef || !ARUse;
208208
}
209209

210-
// isLegalToPruneDependencies - Is it legal to prune dependece between SUI
210+
// isLegalToPruneDependencies - Is it legal to prune dependency between SUI
211211
// and SUJ.
212212
bool isLegalToPruneDependencies(SUnit *SUI, SUnit *SUJ) override {
213213
return false;

llvm/lib/Target/AMDGPU/R600TargetMachine.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
//===----------------------------------------------------------------------===//
88
//
99
/// \file
10-
/// The AMDGPU TargetMachine interface definition for hw codgen targets.
10+
/// The AMDGPU TargetMachine interface definition for hw codegen targets.
1111
//
1212
//===----------------------------------------------------------------------===//
1313

llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ void SIFormMemoryClauses::collectRegUses(const MachineInstr &MI,
241241
}
242242

243243
// Check register def/use conflicts, occupancy limits and collect def/use maps.
244-
// Return true if instruction can be bundled with previous. It it cannot
244+
// Return true if instruction can be bundled with previous. If it cannot
245245
// def/use maps are not updated.
246246
bool SIFormMemoryClauses::processRegUses(const MachineInstr &MI,
247247
RegUse &Defs, RegUse &Uses,

llvm/lib/Target/AMDGPU/SIFrameLowering.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1200,7 +1200,7 @@ void SIFrameLowering::processFunctionBeforeFrameFinalized(
12001200
}
12011201
}
12021202

1203-
// Stack slot coloring may assign different objets to the same stack slot.
1203+
// Stack slot coloring may assign different objects to the same stack slot.
12041204
// If not, then the VGPR to AGPR spill slot is dead.
12051205
for (unsigned FI : SpillFIs.set_bits())
12061206
if (!NonVGPRSpillFIs.test(FI))

0 commit comments

Comments
 (0)