Skip to content

Commit 7767c58

Browse files
[lldb][DWARF] Search for symbols in all external modules (llvm#75927)
The way this code was updated in dd95877 meant that if the first module did not have the symbol, the iteration stopped as returning true means stop. So only if every module had the symbol would we find it, in the last module. Invert the condition to break when we find the first instance, which is what the previous code did.
1 parent f1156eb commit 7767c58

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ TypeSP DWARFASTParserClang::ParseTypeFromClangModule(const SymbolContext &sc,
175175
*sc.comp_unit, results.GetSearchedSymbolFiles(), [&](Module &module) {
176176
module.FindTypes(query, results);
177177
pcm_type_sp = results.GetTypeMap().FirstType();
178-
return !pcm_type_sp;
178+
return (bool)pcm_type_sp;
179179
});
180180
}
181181

0 commit comments

Comments
 (0)