Skip to content

Commit 812a906

Browse files
committed
[sanitizers][NFC] Change typesto avoid warnings
Warning was enabled by D94640
1 parent 3744ba2 commit 812a906

File tree

2 files changed

+18
-19
lines changed

2 files changed

+18
-19
lines changed

compiler-rt/lib/sanitizer_common/sanitizer_allocator_primary64.h

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -371,8 +371,7 @@ class SizeClassAllocator64 {
371371
}
372372
~PackedCounterArray() {
373373
if (buffer) {
374-
memory_mapper->UnmapPackedCounterArrayBuffer(
375-
reinterpret_cast<uptr>(buffer), buffer_size);
374+
memory_mapper->UnmapPackedCounterArrayBuffer(buffer, buffer_size);
376375
}
377376
}
378377

@@ -803,17 +802,16 @@ class SizeClassAllocator64 {
803802
return released_bytes;
804803
}
805804

806-
uptr MapPackedCounterArrayBuffer(uptr buffer_size) {
805+
void *MapPackedCounterArrayBuffer(uptr buffer_size) {
807806
// TODO(alekseyshl): The idea to explore is to check if we have enough
808807
// space between num_freed_chunks*sizeof(CompactPtrT) and
809808
// mapped_free_array to fit buffer_size bytes and use that space instead
810809
// of mapping a temporary one.
811-
return reinterpret_cast<uptr>(
812-
MmapOrDieOnFatalError(buffer_size, "ReleaseToOSPageCounters"));
810+
return MmapOrDieOnFatalError(buffer_size, "ReleaseToOSPageCounters");
813811
}
814812

815-
void UnmapPackedCounterArrayBuffer(uptr buffer, uptr buffer_size) {
816-
UnmapOrDie(reinterpret_cast<void *>(buffer), buffer_size);
813+
void UnmapPackedCounterArrayBuffer(void *buffer, uptr buffer_size) {
814+
UnmapOrDie(buffer, buffer_size);
817815
}
818816

819817
// Releases [from, to) range of pages back to OS.

compiler-rt/lib/sanitizer_common/tests/sanitizer_allocator_test.cpp

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1081,11 +1081,11 @@ class NoMemoryMapper {
10811081

10821082
NoMemoryMapper() : last_request_buffer_size(0) {}
10831083

1084-
uptr MapPackedCounterArrayBuffer(uptr buffer_size) {
1084+
void *MapPackedCounterArrayBuffer(uptr buffer_size) {
10851085
last_request_buffer_size = buffer_size;
1086-
return 0;
1086+
return nullptr;
10871087
}
1088-
void UnmapPackedCounterArrayBuffer(uptr buffer, uptr buffer_size) {}
1088+
void UnmapPackedCounterArrayBuffer(void *buffer, uptr buffer_size) {}
10891089
};
10901090

10911091
class RedZoneMemoryMapper {
@@ -1100,14 +1100,15 @@ class RedZoneMemoryMapper {
11001100
UnmapOrDie(buffer, 3 * GetPageSize());
11011101
}
11021102

1103-
uptr MapPackedCounterArrayBuffer(uptr buffer_size) {
1103+
void *MapPackedCounterArrayBuffer(uptr buffer_size) {
11041104
const auto page_size = GetPageSize();
11051105
CHECK_EQ(buffer_size, page_size);
1106-
memset(reinterpret_cast<void*>(reinterpret_cast<uptr>(buffer) + page_size),
1107-
0, page_size);
1108-
return reinterpret_cast<uptr>(buffer) + page_size;
1106+
void *p =
1107+
reinterpret_cast<void *>(reinterpret_cast<uptr>(buffer) + page_size);
1108+
memset(p, 0, page_size);
1109+
return p;
11091110
}
1110-
void UnmapPackedCounterArrayBuffer(uptr buffer, uptr buffer_size) {}
1111+
void UnmapPackedCounterArrayBuffer(void *buffer, uptr buffer_size) {}
11111112

11121113
private:
11131114
void *buffer;
@@ -1227,12 +1228,12 @@ class ReleasedPagesTrackingMemoryMapper {
12271228
public:
12281229
std::set<u32> reported_pages;
12291230

1230-
uptr MapPackedCounterArrayBuffer(uptr buffer_size) {
1231+
void *MapPackedCounterArrayBuffer(uptr buffer_size) {
12311232
reported_pages.clear();
1232-
return reinterpret_cast<uptr>(calloc(1, buffer_size));
1233+
return calloc(1, buffer_size);
12331234
}
1234-
void UnmapPackedCounterArrayBuffer(uptr buffer, uptr buffer_size) {
1235-
free(reinterpret_cast<void*>(buffer));
1235+
void UnmapPackedCounterArrayBuffer(void *buffer, uptr buffer_size) {
1236+
free(buffer);
12361237
}
12371238

12381239
void ReleasePageRangeToOS(u32 from, u32 to) {

0 commit comments

Comments
 (0)