Skip to content

Commit 912551d

Browse files
alanzhao1zmodem
authored andcommitted
Add the /nologo flag to llvm-ml
This flag is present in MSVC's ml.exe to suppress copyright info output. LLVM doesn't output copyright info, so this flag does nothing in llvm-ml. We still add this flag though so that when llvm-ml is used as a drop-in replacement for MSVC ml.exe, we don't get any extra warnings. Furthermore, this behavior is also consistent with other llvm binaries for Windows (e.g. clang-cl, llvm-mt, lld-link, etc.) Differential revision: https://reviews.llvm.org/D123068
1 parent 28d7931 commit 912551d

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

llvm/test/tools/llvm-ml/basic.test

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1-
# RUN: not llvm-ml %t.blah.asm /Fo /dev/null 2>&1 | FileCheck -DMSG=%errc_ENOENT --check-prefix=ENOENT %s
1+
# RUN: not llvm-ml %t.blah.asm /nologo /Fo /dev/null 2>&1 | FileCheck -DMSG=%errc_ENOENT --check-prefix=ENOENT %s
22

3+
# ENOENT-NOT: nologo
34
# ENOENT: {{.*}}.blah.asm: [[MSG]]

llvm/tools/llvm-ml/Opts.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ def assemble_only : MLFlag<"c">, HelpText<"Assemble only; do not link">;
6565
def define : MLJoinedOrSeparate<"D">, MetaVarName<"<macro>=<value>">,
6666
HelpText<"Define <macro> to <value> (or blank if <value> "
6767
"omitted)">;
68+
def no_logo : MLFlag<"nologo">, HelpText<"">;
6869
def output_file : MLJoinedOrSeparate<"Fo">, HelpText<"Names the output file">;
6970
def include_path : MLJoinedOrSeparate<"I">,
7071
HelpText<"Sets path for include files">;
@@ -101,7 +102,6 @@ def pascal_conventions : UnsupportedFlag<"Gc">, HelpText<"">;
101102
def c_conventions : UnsupportedFlag<"Gd">, HelpText<"">;
102103
def stdcall_conventions : UnsupportedFlag<"GZ">, HelpText<"">;
103104
def extern_name_limit : UnsupportedSeparate<"H">, HelpText<"">;
104-
def nologo : UnsupportedFlag<"nologo">, HelpText<"">;
105105
def omf_object_file : UnsupportedFlag<"omf">, HelpText<"">;
106106
def full_listing : UnsupportedFlag<"Sa">, HelpText<"">;
107107
def first_pass_listing : UnsupportedFlag<"Sf">, HelpText<"">;

0 commit comments

Comments
 (0)