Revert "[flang] Support lowering of intrinsic GET_COMMAND"

This reverts commit 86ea67e.

Author: PeixinQiao

flang/include/flang/Optimizer/Builder/Runtime/Command.h

@@ -23,14 +23,6 @@ namespace fir::runtime {
 /// Generate call to COMMAND_ARGUMENT_COUNT intrinsic runtime routine.
 mlir::Value genCommandArgumentCount(fir::FirOpBuilder &, mlir::Location);
 
-/// Generate a call to the GetCommand runtime function which implements the
-/// GET_COMMAND intrinsic.
-/// \p command, \p length and \p errmsg must be fir.box that can be absent (but
-/// not null mlir values). The status value is returned.
-mlir::Value genGetCommand(fir::FirOpBuilder &, mlir::Location,
-                          mlir::Value command, mlir::Value length,
-                          mlir::Value errmsg);
-
 /// Generate a call to the GetCommandArgument runtime function which implements
 /// the GET_COMMAND_ARGUMENT intrinsic.
 /// \p value, \p length and \p errmsg must be fir.box that can be absent (but

flang/lib/Lower/IntrinsicCall.cpp

@@ -505,7 +505,6 @@ struct IntrinsicLibrary {
   mlir::Value genFloor(mlir::Type, llvm::ArrayRef<mlir::Value>);
   mlir::Value genFraction(mlir::Type resultType,
                           mlir::ArrayRef<mlir::Value> args);
-  void genGetCommand(mlir::ArrayRef<fir::ExtendedValue> args);
   void genGetCommandArgument(mlir::ArrayRef<fir::ExtendedValue> args);
   void genGetEnvironmentVariable(llvm::ArrayRef<fir::ExtendedValue>);
   fir::ExtendedValue genIall(mlir::Type, llvm::ArrayRef<fir::ExtendedValue>);
@@ -803,13 +802,6 @@ static constexpr IntrinsicHandler handlers[]{
     {"exponent", &I::genExponent},
     {"floor", &I::genFloor},
     {"fraction", &I::genFraction},
-    {"get_command",
-     &I::genGetCommand,
-     {{{"command", asBox, handleDynamicOptional},
-       {"length", asBox, handleDynamicOptional},
-       {"status", asAddr, handleDynamicOptional},
-       {"errmsg", asBox, handleDynamicOptional}}},
-     /*isElemental=*/false},
     {"get_command_argument",
      &I::genGetCommandArgument,
      {{{"number", asValue},
@@ -3196,44 +3188,6 @@ mlir::Value IntrinsicLibrary::genFraction(mlir::Type resultType,
       fir::runtime::genFraction(builder, loc, fir::getBase(args[0])));
 }
 
-// GET_COMMAND
-void IntrinsicLibrary::genGetCommand(llvm::ArrayRef<fir::ExtendedValue> args) {
-  assert(args.size() == 4);
-  const fir::ExtendedValue &command = args[0];
-  const fir::ExtendedValue &length = args[1];
-  const fir::ExtendedValue &status = args[2];
-  const fir::ExtendedValue &errmsg = args[3];
-
-  // If none of the optional parameters are present, do nothing.
-  if (!isStaticallyPresent(command) && !isStaticallyPresent(length) &&
-      !isStaticallyPresent(status) && !isStaticallyPresent(errmsg))
-    return;
-
-  mlir::Type boxNoneTy = fir::BoxType::get(builder.getNoneType());
-  mlir::Value commandBox =
-      isStaticallyPresent(command)
-          ? fir::getBase(command)
-          : builder.create<fir::AbsentOp>(loc, boxNoneTy).getResult();
-  mlir::Value lenBox =
-      isStaticallyPresent(length)
-          ? fir::getBase(length)
-          : builder.create<fir::AbsentOp>(loc, boxNoneTy).getResult();
-  mlir::Value errBox =
-      isStaticallyPresent(errmsg)
-          ? fir::getBase(errmsg)
-          : builder.create<fir::AbsentOp>(loc, boxNoneTy).getResult();
-  mlir::Value stat =
-      fir::runtime::genGetCommand(builder, loc, commandBox, lenBox, errBox);
-  if (isStaticallyPresent(status)) {
-    mlir::Value statAddr = fir::getBase(status);
-    mlir::Value statIsPresentAtRuntime =
-        builder.genIsNotNullAddr(loc, statAddr);
-    builder.genIfThen(loc, statIsPresentAtRuntime)
-        .genThen([&]() { builder.createStoreWithConvert(loc, stat, statAddr); })
-        .end();
-  }
-}
-
 // GET_COMMAND_ARGUMENT
 void IntrinsicLibrary::genGetCommandArgument(
     llvm::ArrayRef<fir::ExtendedValue> args) {

flang/lib/Optimizer/Builder/Runtime/Command.cpp

@@ -32,22 +32,6 @@ mlir::Value fir::runtime::genCommandArgumentCount(fir::FirOpBuilder &builder,
   return builder.create<fir::CallOp>(loc, argumentCountFunc).getResult(0);
 }
 
-mlir::Value fir::runtime::genGetCommand(fir::FirOpBuilder &builder,
-                                        mlir::Location loc, mlir::Value command,
-                                        mlir::Value length,
-                                        mlir::Value errmsg) {
-  auto runtimeFunc =
-      fir::runtime::getRuntimeFunc<mkRTKey(GetCommand)>(loc, builder);
-  mlir::FunctionType runtimeFuncTy = runtimeFunc.getFunctionType();
-  mlir::Value sourceFile = fir::factory::locationToFilename(builder, loc);
-  mlir::Value sourceLine =
-      fir::factory::locationToLineNo(builder, loc, runtimeFuncTy.getInput(4));
-  llvm::SmallVector<mlir::Value> args =
-      fir::runtime::createArguments(builder, loc, runtimeFuncTy, command,
-                                    length, errmsg, sourceFile, sourceLine);
-  return builder.create<fir::CallOp>(loc, runtimeFunc, args).getResult(0);
-}
-
 mlir::Value fir::runtime::genGetCommandArgument(
     fir::FirOpBuilder &builder, mlir::Location loc, mlir::Value number,
     mlir::Value value, mlir::Value length, mlir::Value errmsg) {