Skip to content

Commit c0f8115

Browse files
committed
[mlir][linalg] Only generate one var for an attrUse.
Some variables are unused after D97383 landed. We should generate one symbol for one attrUse. Reviewed By: stellaraccident Differential Revision: https://reviews.llvm.org/D97794
1 parent bbdb4c8 commit c0f8115

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

mlir/test/mlir-linalg-ods-gen/test-linalg-ods-gen.tc

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -122,16 +122,14 @@ attr(
122122
// IMPL-LABEL: ArrayAttr Test5Op::indexing_maps() {
123123
// IMPL: auto cst0 = getAffineConstantExpr(strides().getValue<int>({ 0 }), context);
124124
// IMPL: auto cst1 = getAffineConstantExpr(strides().getValue<int>({ 1 }), context);
125-
// IMPL: auto cst2 = getAffineConstantExpr(strides().getValue<int>({ 0 }), context);
126-
// IMPL: auto cst3 = getAffineConstantExpr(strides().getValue<int>({ 1 }), context);
127125
// IMPL: auto map0 = AffineMap::get(7, 9, {d0, d1 * s7 + d4, d2 * s8 + d5, d6}, context);
128-
// IMPL: map0 = map0.replaceDimsAndSymbols({}, { s0, s1, s2, s3, s4, s5, s6, cst2, cst3 }, 7, 0);
126+
// IMPL: map0 = map0.replaceDimsAndSymbols({}, { s0, s1, s2, s3, s4, s5, s6, cst0, cst1 }, 7, 0);
129127
// IMPL: map0 = simplifyAffineMap(map0);
130128
// IMPL: auto map1 = AffineMap::get(7, 9, {d3, d4, d5, d6}, context);
131-
// IMPL: map1 = map1.replaceDimsAndSymbols({}, { s0, s1, s2, s3, s4, s5, s6, cst2, cst3 }, 7, 0);
129+
// IMPL: map1 = map1.replaceDimsAndSymbols({}, { s0, s1, s2, s3, s4, s5, s6, cst0, cst1 }, 7, 0);
132130
// IMPL: map1 = simplifyAffineMap(map1);
133131
// IMPL: auto map2 = AffineMap::get(7, 7, {d0, d1, d2, d3}, context);
134-
// IMPL: map2 = map2.replaceDimsAndSymbols({}, { s0, s1, s2, s3, s4, s5, s6, cst2, cst3 }, 7, 0);
132+
// IMPL: map2 = map2.replaceDimsAndSymbols({}, { s0, s1, s2, s3, s4, s5, s6, cst0, cst1 }, 7, 0);
135133
// IMPL: map2 = simplifyAffineMap(map2);
136134
// IMPL: return {{.+}}.getAffineMapArrayAttr({ map0, map1, map2 });
137135
//

mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1306,12 +1306,11 @@ TCParser::parseAffineExprs(EagerDiscoveryMode discoveryMode,
13061306
result.symbol = getAffineSymbolExpr(symbols.size(), parser.context);
13071307
symbols.emplace_back("<attr-use>", result.symbol);
13081308
registeredAttrUseToSymbol[result.getKey()] = result.symbol;
1309+
attrUses.push_back(result);
13091310
} else {
13101311
result.symbol = symbolIt->second;
13111312
}
13121313

1313-
attrUses.push_back(result);
1314-
13151314
return result.symbol;
13161315
};
13171316

0 commit comments

Comments
 (0)