Skip to content

Commit ca0bb0e

Browse files
author
serge-sans-paille
committed
Make sure some types are indeed trivially_copyable per llvm::is_trivially_copyable
Test a few types used as llvm::SmallVector parameter. It is important to ensure we have a consistent behavior for these types to prevent ABI issues as the one we met in https://bugs.llvm.org/show_bug.cgi?id=39427. Differential Revision: https://reviews.llvm.org/D96536
1 parent 542d9c2 commit ca0bb0e

File tree

1 file changed

+26
-0
lines changed

1 file changed

+26
-0
lines changed

llvm/unittests/Support/TypeTraitsTest.cpp

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9+
#include "llvm/ADT/FunctionExtras.h"
10+
#include "llvm/ADT/Optional.h"
11+
#include "llvm/ADT/PointerIntPair.h"
12+
#include "llvm/ADT/SmallString.h"
13+
#include "llvm/ADT/SmallVector.h"
14+
#include "llvm/ADT/StringRef.h"
915
#include "llvm/Support/type_traits.h"
1016
#include "gtest/gtest.h"
1117

@@ -92,6 +98,26 @@ TEST(Triviality, Tester) {
9298
TrivialityTester<B &&, false, true>();
9399
}
94100

101+
// Test that the following ADT behave as expected wrt. trivially copyable trait
102+
//
103+
// NB: It is important that this trait behaves the same for (at least) these
104+
// types for all supported compilers to prevent ABI issue when llvm is compiled
105+
// with compiler A and an other project using llvm is compiled with compiler B.
106+
107+
TEST(Triviality, ADT) {
108+
109+
TrivialityTester<llvm::SmallVector<int>, false, false>();
110+
TrivialityTester<llvm::SmallString<8>, false, false>();
111+
112+
TrivialityTester<std::function<int()>, false, false>();
113+
TrivialityTester<std::pair<int, bool>, true, true>();
114+
TrivialityTester<llvm::unique_function<int()>, false, false>();
115+
TrivialityTester<llvm::StringRef, true, true>();
116+
TrivialityTester<llvm::ArrayRef<int>, true, true>();
117+
TrivialityTester<llvm::PointerIntPair<int *, 2>, true, true>();
118+
TrivialityTester<llvm::Optional<int>, true, true>();
119+
}
120+
95121
} // namespace triviality
96122

97123
} // end anonymous namespace

0 commit comments

Comments
 (0)