Skip to content

Commit caa5167

Browse files
committed
Revert "[lldb] Fix data race in ConnectionFileDescriptor"
This reverts commit 0bdbe7b because it broke the bots.
1 parent c8aab9b commit caa5167

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

lldb/include/lldb/Host/posix/ConnectionFileDescriptorPosix.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ class ConnectionFileDescriptor : public Connection {
131131
lldb::IOObjectSP m_io_sp;
132132

133133
Pipe m_pipe;
134-
mutable std::recursive_mutex m_mutex;
134+
std::recursive_mutex m_mutex;
135135
std::atomic<bool> m_shutting_down; // This marks that we are shutting down so
136136
// if we get woken up from
137137
// BytesAvailable to disconnect, we won't try to read again.

lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@ void ConnectionFileDescriptor::CloseCommandPipe() {
118118
}
119119

120120
bool ConnectionFileDescriptor::IsConnected() const {
121-
std::lock_guard<std::recursive_mutex> guard(m_mutex);
122121
return m_io_sp && m_io_sp->IsValid();
123122
}
124123

0 commit comments

Comments
 (0)