Skip to content

Commit cac4e2f

Browse files
committed
[CUDA][HIP] Fix gpu.used.external
Rename gpu.used.external as __clang_gpu_used_external as ptxas does not allow . in global variable name. Fixes: llvm#54934 Reviewed by: Joseph Huber, Artem Belevich Differential Revision: https://reviews.llvm.org/D123946
1 parent 8078721 commit cac4e2f

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

clang/lib/CodeGen/CodeGenModule.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,7 @@ void CodeGenModule::Release() {
599599

600600
auto *GV = new llvm::GlobalVariable(
601601
getModule(), ATy, false, llvm::GlobalValue::AppendingLinkage,
602-
llvm::ConstantArray::get(ATy, UsedArray), "gpu.used.external");
602+
llvm::ConstantArray::get(ATy, UsedArray), "__clang_gpu_used_external");
603603
addCompilerUsedGlobal(GV);
604604
}
605605

clang/test/CodeGenCUDA/host-used-extern.cu

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,19 @@
1111

1212
#include "Inputs/cuda.h"
1313

14-
// CHECK-LABEL: @gpu.used.external = appending {{.*}}global
14+
// CHECK-LABEL: @__clang_gpu_used_external = appending {{.*}}global
1515
// CHECK-DAG: @_Z7kernel1v
1616
// CHECK-DAG: @_Z7kernel4v
1717
// CHECK-DAG: @var1
18-
// CHECK-LABEL: @llvm.compiler.used = {{.*}} @gpu.used.external
19-
20-
// NEG-NOT: @gpu.used.external = {{.*}} @_Z7kernel2v
21-
// NEG-NOT: @gpu.used.external = {{.*}} @_Z7kernel3v
22-
// NEG-NOT: @gpu.used.external = {{.*}} @var2
23-
// NEG-NOT: @gpu.used.external = {{.*}} @var3
24-
// NORDC-NOT: @gpu.used.external = {{.*}} @_Z7kernel1v
25-
// NORDC-NOT: @gpu.used.external = {{.*}} @_Z7kernel4v
26-
// NORDC-NOT: @gpu.used.external = {{.*}} @var1
18+
// CHECK-LABEL: @llvm.compiler.used = {{.*}} @__clang_gpu_used_external
19+
20+
// NEG-NOT: @__clang_gpu_used_external = {{.*}} @_Z7kernel2v
21+
// NEG-NOT: @__clang_gpu_used_external = {{.*}} @_Z7kernel3v
22+
// NEG-NOT: @__clang_gpu_used_external = {{.*}} @var2
23+
// NEG-NOT: @__clang_gpu_used_external = {{.*}} @var3
24+
// NORDC-NOT: @__clang_gpu_used_external = {{.*}} @_Z7kernel1v
25+
// NORDC-NOT: @__clang_gpu_used_external = {{.*}} @_Z7kernel4v
26+
// NORDC-NOT: @__clang_gpu_used_external = {{.*}} @var1
2727

2828
__global__ void kernel1();
2929

0 commit comments

Comments
 (0)