Skip to content

Commit fcf1a10

Browse files
committed
[OMPX] Change thread_dim to block_dim and the original block_dim to grid_dim
There is no `threadDim` in CUDA. Instead, it is `blockDim`. Then the current `blockDim` is `gridDim` in CUDA. Reviewed By: jhuber6 Differential Revision: https://reviews.llvm.org/D157051
1 parent c171ed4 commit fcf1a10

File tree

6 files changed

+14
-14
lines changed

6 files changed

+14
-14
lines changed

openmp/libomptarget/DeviceRTL/src/Mapping.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -373,8 +373,8 @@ __attribute__((noinline)) uint32_t __kmpc_get_warp_size() {
373373
extern "C" int ompx_##NAME(int Dim) { return mapping::MAPPER_NAME(Dim); }
374374

375375
_TGT_KERNEL_LANGUAGE(thread_id, getThreadIdInBlock)
376-
_TGT_KERNEL_LANGUAGE(thread_dim, getNumberOfThreadsInBlock)
377376
_TGT_KERNEL_LANGUAGE(block_id, getBlockIdInKernel)
378-
_TGT_KERNEL_LANGUAGE(block_dim, getNumberOfBlocksInKernel)
377+
_TGT_KERNEL_LANGUAGE(block_dim, getNumberOfThreadsInBlock)
378+
_TGT_KERNEL_LANGUAGE(grid_dim, getNumberOfBlocksInKernel)
379379

380380
#pragma omp end declare target

openmp/libomptarget/test/api/ompx_3d.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ void foo(int device) {
1111
device(device) thread_limit(2) num_teams(5)
1212
for (int i = 0; i < 1000; ++i) {
1313
if (i == 42) {
14-
tid = ompx_thread_dim_x();
14+
tid = ompx_block_dim_x();
1515
bid = ompx_block_id_x();
16-
bdim = ompx_block_dim_x();
16+
bdim = ompx_grid_dim_x();
1717
}
1818
}
1919
// CHECK: tid: 2, bid: 1, bdim: 5

openmp/libomptarget/test/api/ompx_3d.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ void foo(int device) {
1111
device(device) thread_limit(2) num_teams(5)
1212
for (int i = 0; i < 1000; ++i) {
1313
if (i == 42) {
14-
tid = ompx::thread_dim_x();
14+
tid = ompx::block_dim_x();
1515
bid = ompx::block_id_x();
16-
bdim = ompx::block_dim_x();
16+
bdim = ompx::grid_dim_x();
1717
}
1818
}
1919
// CHECK: tid: 2, bid: 1, bdim: 5

openmp/libomptarget/test/offloading/ompx_coords.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ int main(int argc, char **argv) {
3131
{
3232
int tid = ompx_thread_id_x();
3333
int bid = ompx_block_id_x();
34-
int tdim = ompx_thread_dim_x();
34+
int tdim = ompx_block_dim_x();
3535
int gid = tid + bid * tdim;
3636
if (gid < N) {
3737
X[gid].tid = tid;

openmp/libomptarget/test/offloading/ompx_saxpy_mixed.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ int main(int argc, char **argv) {
3333
{
3434
int tid = ompx_thread_id_x();
3535
int bid = ompx_block_id_x();
36-
int tdim = ompx_thread_dim_x();
36+
int tdim = ompx_block_dim_x();
3737
int gid = tid + bid * tdim;
3838
if (gid < N)
3939
Y[gid] = a * X[gid] + Y[gid];

openmp/runtime/src/include/ompx.h.var

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ enum {
5858

5959
_TGT_KERNEL_LANGUAGE_HOST_IMPL_GRID_C(thread_id,
6060
omp_get_ancestor_thread_num(Dim + 1))
61-
_TGT_KERNEL_LANGUAGE_HOST_IMPL_GRID_C(thread_dim, omp_get_team_size(Dim + 1))
61+
_TGT_KERNEL_LANGUAGE_HOST_IMPL_GRID_C(block_dim, omp_get_team_size(Dim + 1))
6262
_TGT_KERNEL_LANGUAGE_HOST_IMPL_GRID_C(block_id, 0)
63-
_TGT_KERNEL_LANGUAGE_HOST_IMPL_GRID_C(block_dim, 1)
63+
_TGT_KERNEL_LANGUAGE_HOST_IMPL_GRID_C(grid_dim, 1)
6464
#undef _TGT_KERNEL_LANGUAGE_HOST_IMPL_GRID_C
6565
///}
6666

@@ -100,9 +100,9 @@ _TGT_KERNEL_LANGUAGE_DECL_SYNC_C(void, sync_block_divergent, int Ordering);
100100
static inline int ompx_##NAME##_z() { return ompx_##NAME(ompx_dim_z); }
101101

102102
_TGT_KERNEL_LANGUAGE_DECL_GRID_C(thread_id)
103-
_TGT_KERNEL_LANGUAGE_DECL_GRID_C(thread_dim)
104-
_TGT_KERNEL_LANGUAGE_DECL_GRID_C(block_id)
105103
_TGT_KERNEL_LANGUAGE_DECL_GRID_C(block_dim)
104+
_TGT_KERNEL_LANGUAGE_DECL_GRID_C(block_id)
105+
_TGT_KERNEL_LANGUAGE_DECL_GRID_C(grid_dim)
106106
#undef _TGT_KERNEL_LANGUAGE_DECL_GRID_C
107107
///}
108108

@@ -137,9 +137,9 @@ enum {
137137
static inline int NAME##_z() noexcept { return NAME(ompx_dim_z); }
138138

139139
_TGT_KERNEL_LANGUAGE_HOST_IMPL_GRID_CXX(thread_id)
140-
_TGT_KERNEL_LANGUAGE_HOST_IMPL_GRID_CXX(thread_dim)
141-
_TGT_KERNEL_LANGUAGE_HOST_IMPL_GRID_CXX(block_id)
142140
_TGT_KERNEL_LANGUAGE_HOST_IMPL_GRID_CXX(block_dim)
141+
_TGT_KERNEL_LANGUAGE_HOST_IMPL_GRID_CXX(block_id)
142+
_TGT_KERNEL_LANGUAGE_HOST_IMPL_GRID_CXX(grid_dim)
143143
#undef _TGT_KERNEL_LANGUAGE_HOST_IMPL_GRID_CXX
144144
///}
145145

0 commit comments

Comments
 (0)