Skip to content
This repository was archived by the owner on Feb 5, 2019. It is now read-only.

Commit ac08c79

Browse files
committed
Merging r310796:
------------------------------------------------------------------------ r310796 | asb | 2017-08-13 11:49:33 -0700 (Sun, 13 Aug 2017) | 16 lines Remove RISCV from LLVM_ALL_TARGETS in CMakeLists.txt It was mistakenly added to that list in D23560 (committed in rL285712). RISCV is an experimental backend and should never have been in that list, I mistakenly interpreted LLVM_ALL_TARGETS as a list of all targets rather than targets to build by default. Unfortunately, because of this the RISCV backend has been building by default when it shouldn't be. This commet adds a description comment, which should help to avoid such mistakes in the future. See my message to llvm-dev for more information and analysis <http://lists.llvm.org/pipermail/llvm-dev/2017-August/116347.html>. Differential Revision: https://reviews.llvm.org/D36538 ------------------------------------------------------------------------ git-svn-id: https://llvm.org/svn/llvm-project/llvm/branches/release_50@310900 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent 801c03e commit ac08c79

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,7 @@ set(LLVM_CMAKE_PATH ${LLVM_MAIN_SRC_DIR}/cmake/modules)
314314
set(LLVM_EXAMPLES_BINARY_DIR ${LLVM_BINARY_DIR}/examples)
315315
set(LLVM_INCLUDE_DIR ${CMAKE_CURRENT_BINARY_DIR}/include)
316316

317+
# List of all targets to be built by default:
317318
set(LLVM_ALL_TARGETS
318319
AArch64
319320
AMDGPU
@@ -325,7 +326,6 @@ set(LLVM_ALL_TARGETS
325326
MSP430
326327
NVPTX
327328
PowerPC
328-
RISCV
329329
Sparc
330330
SystemZ
331331
X86

0 commit comments

Comments
 (0)