Skip to content

Add missing unsafe features #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2017
Merged

Conversation

matthewjasper
Copy link
Contributor

Add unions and unsafe traits to the list of unsafe features.

Copy link
Contributor

@Havvy Havvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for adding these to the list.

I think the ommision of "of a union" to the second part of the union line makes the phrasing hard to read. Could also just make it another bullet point.

src/unsafety.md Outdated
@@ -8,4 +8,7 @@ Rust:

- Dereferencing a [raw pointer](types.html#pointer-types).
- Reading or writing a [mutable static variable](items.html#mutable-statics).
- Reading a field of a [`union`](items.html#unions), or writing to a field that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"write to a field of a union"

@Havvy Havvy merged commit 51b6edc into rust-lang:master Sep 22, 2017
@Havvy
Copy link
Contributor

Havvy commented Sep 22, 2017

Thanks 💟

@matthewjasper matthewjasper deleted the unions-unsafe branch October 18, 2018 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants