Moved grouped expressions to its own page #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewjasper
requested changes
Mar 10, 2018
src/expressions/grouped-expr.md
Outdated
| expression. Parentheses can be used to explicitly specify evaluation order | ||
| within an expression. | ||
|
|
||
| This operator cannot be overloaded. |
There was a problem hiding this comment.
Yes, please remove this.
src/expressions.md
Outdated
| @@ -247,6 +247,7 @@ Many of the following operators and expressions can also be overloaded for | |||
| other types using traits in `std::ops` or `std::cmp`. These traits also | |||
| exist in `core::ops` and `core::cmp` with the same names. | |||
|
|
|||
| [grouped]: expressions/grouped-expr.html | |||
There was a problem hiding this comment.
Can this be put between field and literals so this list stays in alphabetical order?
src/expressions/grouped-expr.md
Outdated
| # let a = A{f: || "The field f"}; | ||
| # | ||
| assert_eq!( a.f (), "The method f"); | ||
| assert_eq!( (a.f)(), "The field f"); |
There was a problem hiding this comment.
Can you remove the first space inside the macro here?
assert_eq!( a.f (), "The method f");
assert_eq!((a.f)(), "The field f");
brauliobz
force-pushed
the
grouped_expression
branch
from
22d3b57 to
fd0c4c4
Compare
brauliobz
force-pushed
the
grouped_expression
branch
from
fd0c4c4 to
9ae7b6f
Compare
matthewjasper
approved these changes
Mar 10, 2018
Merged
Havvy
approved these changes
Mar 11, 2018
|
LGTM. I'm hesitant to merge because I'm not sure why @matthewjasper didn't earlier. |
|
@Havvy I didn't merge to give you a chance to give feedback if you wanted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and added another example of its use.
Should I remove this bit
This operator cannot be overloaded.? It is not really an operator.