Add u128 and i128 tokens #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally all other tokens were sorted `u..` first, then `i..` - so I re-ordered `usize` & `isize` to conform
Also sorted `usize` & `isize` to match the sorting of other literals.
alercah
approved these changes
May 26, 2018
|
Somebody beat this commit to add u128 & i128 :) . After merging from master - there is only the order change of isize & usize to match the other types left in this commit. |
|
💟 That was bstrie. Both of your PRs were pretty close to each other, but their's were the one I was looking at first... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally all other tokens were sorted
u..first, theni..- so I re-orderedusize&isizeto conform