Skip to content

Commit 41856e2

Browse files
author
Alex Muscar
committed
fix: make signature info response conform to spec
This addreses #10464. This patch picks up `lsp-types` 0.90.1, which serialises the `SignatureInformation` and `ParameterInformation` with the right casing. It also adds `activeSignature` field as part of the top-level signature response. It keeps `activeParameter` at the top-level for backwards compatibility.
1 parent 4ff0377 commit 41856e2

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Cargo.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/rust-analyzer/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ crossbeam-channel = "0.5.0"
2222
dissimilar = "1.0.2"
2323
itertools = "0.10.0"
2424
jod-thread = "0.1.0"
25-
lsp-types = { version = "0.90.0", features = ["proposed"] }
25+
lsp-types = { version = "0.90.1", features = ["proposed"] }
2626
parking_lot = "0.11.0"
2727
xflags = "0.2.1"
2828
oorandom = "11.1.2"

crates/rust-analyzer/src/to_proto.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ pub(crate) fn signature_help(
399399
};
400400
lsp_types::SignatureHelp {
401401
signatures: vec![signature],
402-
active_signature: None,
402+
active_signature: Some(0),
403403
active_parameter,
404404
}
405405
}

0 commit comments

Comments
 (0)