File tree Expand file tree Collapse file tree 3 files changed +10
-2
lines changed
ide_completion/src/completions Expand file tree Collapse file tree 3 files changed +10
-2
lines changed Original file line number Diff line number Diff line change @@ -536,6 +536,7 @@ fn main() {
536
536
}
537
537
538
538
#[ test]
539
+ #[ ignore = "FIXME: non-trait assoc items completion is unsupported yet, see FIXME in the import_assets.rs for more details" ]
539
540
fn associated_struct_const_unqualified ( ) {
540
541
check_assist (
541
542
qualify_path,
Original file line number Diff line number Diff line change @@ -949,7 +949,7 @@ fn main() {
949
949
}
950
950
951
951
#[ test]
952
- fn local_assoc_items_are_omitted ( ) {
952
+ fn unqualified_assoc_items_are_omitted ( ) {
953
953
check (
954
954
r#"
955
955
mod something {
Original file line number Diff line number Diff line change @@ -256,7 +256,14 @@ fn path_applicable_imports(
256
256
sema,
257
257
current_crate,
258
258
path_candidate. name . clone ( ) ,
259
- // unqualified assoc items are not valid syntax
259
+ // FIXME: we could look up assoc items by the input and propose those in completion,
260
+ // but that requries more preparation first:
261
+ // * store non-trait assoc items in import_map to fully enable this lookup
262
+ // * ensure that does not degrade the performance (bencmark it)
263
+ // * write more logic to check for corresponding trait presence requirement (we're unable to flyimport multiple item right now)
264
+ // * improve the associated completion item matching and/or scoring to ensure no noisy completions appear
265
+ //
266
+ // see also an ignored test under FIXME comment in the qualify_path.rs module
260
267
AssocItemSearch :: Exclude ,
261
268
Some ( DEFAULT_QUERY_SEARCH_LIMIT ) ,
262
269
)
You can’t perform that action at this time.
0 commit comments